feat(logging): Add formatted message to log events #4292
Conversation
szokeasaurusrex
requested review from
antonpirker
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #4292 +/- ##
==========================================
+ Coverage 79.53% 79.54% +0.01%
==========================================
Files 142 142
Lines 15907 15907
Branches 2722 2722
==========================================
+ Hits 12652 12654 +2
Misses 2389 2389
+ Partials 866 864 -2
|
Send the formatted log event to Sentry in the [`formatted` field](https://develop.sentry.dev/sdk/data-model/event-payloads/message/). This builds on #4291, providing a more robust fix for #3660.
szokeasaurusrex
force-pushed
the
szokeasaurusrex/formatted-logging
branch
from
f4fafea to
296e288
Compare
The way the code was written before this change made it look like log records from the `warnings` module were always being handled by a separate code path. In fact, this separate path is only used for Python 3.10 and below. This change makes it clear that the branch is version specific. That way, when we eventually stop supporting 3.10, it is clear that we can delete this separate block. Depends on: - #4292 - #4291
|
@sentrivana good idea, I will check the example from #3660 before merging.
In any case, this should not be a breaking change, since we group issues based on the |
|
I tested a log with a 
|
The way the code was written before this change made it look like log records from the `warnings` module were always being handled by a separate code path. In fact, this separate path is only used for Python 3.10 and below. This change makes it clear that the branch is version specific. That way, when we eventually stop supporting 3.10, it is clear that we can delete this separate block. Depends on: - #4292 - #4291
The way the code was written before this change made it look like log records from the `warnings` module were always being handled by a separate code path. In fact, this separate path is only used for Python 3.10 and below. This change makes it clear that the branch is version specific. That way, when we eventually stop supporting 3.10, it is clear that we can delete this separate block. Depends on: - #4292 - #4291
Send the formatted log event to Sentry in the
formattedfield.This builds on #4291, providing a more robust fix for #3660.