-
Notifications
You must be signed in to change notification settings - Fork 541
Add top level API for add_atttachment
.
#4360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
❌ 6 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add to MIGRATION_GUIDE.md
I'll add it to the migration guide in the docs
Right! Added it to the migration guide. Its the only "new feature" right now :-) |
Users should not need to get the Scope and add the attachment there, we can do it for them. This has been first [implemented in SDK 3.0](#4360) and is now back ported to 2.x.
This PR also needs an update of the docs to make sure people use the top level API. See this docs issue: getsentry/sentry-docs#13592