Skip to content

Expo Router performance auto instrumentation #2754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krystofwoldrich opened this issue Jan 16, 2023 · 10 comments
Closed

Expo Router performance auto instrumentation #2754

krystofwoldrich opened this issue Jan 16, 2023 · 10 comments
Assignees
Labels
Expo Issues related to Sentry React Native Expo support Platform: React-Native
Milestone

Comments

@krystofwoldrich
Copy link
Member

Description

There is a new router for RN apps Expo Router, currently in RC.

It's built on top of react-navigation so maybe auto instrumentation will work out of the box, but we need to check that.

@marandaneto
Copy link
Contributor

Maybe it works OOTB because its based on one of our integrations that we already support, likely has to be tested but in the case, offering 1st class support.

@marandaneto marandaneto moved this from Needs Discussion to Backlog in [DEPRECATED] Mobile SDKs Jan 27, 2023
@marandaneto
Copy link
Contributor

Let's start by testing if it works OOTB and later prioritize again in case it does not work.

@k1n8t1c
Copy link

k1n8t1c commented Dec 20, 2023

Hi @krystofwoldrich do you have any update on this item?
Dealing with this right now. Expo-router does not have a standard App.js entry point, so I'm trying to figure out if there is a workaround. Looks like I'm not alone: expo/sentry-expo#370
Thanks

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Dec 20, 2023
@hubertdeng123 hubertdeng123 moved this to Waiting for: Product Owner in GitHub Issues with 👀 2 Dec 21, 2023
@kahest
Copy link
Member

kahest commented Dec 21, 2023

Hey @k1n8t1c thanks for flagging this - we're already in the holiday slowdown, but expect updates after the holidays!

@prathmeshgodse
Copy link

Hey @krystofwoldrich please do update us on this issue. I'm working on an Expo project and would definitely appreciate an update on this.

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 2 Jan 2, 2024
@lavaxun
Copy link

lavaxun commented Jan 2, 2024

My team is also implementing sentry for Expo and we hit the same roadblock.
Greatly appreciate for any help on this.

@k1n8t1c
Copy link

k1n8t1c commented Jan 3, 2024

Hey everyone, not sure if this is the preferred route, but in case it helps someone.

Working with expo router, I tried a couple of "hacks",

@krystofwoldrich
Copy link
Member Author

Thank you, everyone, for the messages and for letting us know about your interest, we are currently finalizing the deprecation of the sentry-expo library (#3262).

And following that, we will work on new features like Expo Router Automatic Instrumentation.

@getsantry getsantry bot removed the status in GitHub Issues with 👀 2 Jan 4, 2024
@kahest kahest added Expo Issues related to Sentry React Native Expo support and removed sentry-expo labels Jan 26, 2024
@krystofwoldrich
Copy link
Member Author

krystofwoldrich commented Jan 26, 2024

Todos:

@krystofwoldrich
Copy link
Member Author

Docs are at https://docs.sentry.io/platforms/react-native/performance/instrumentation/expo-router/
Sample code here

const routingInstrumentation = new Sentry.ReactNavigationInstrumentation({
enableTimeToInitialDisplay: !isExpoGo(), // This is not supported in Expo Go.
});

@github-project-automation github-project-automation bot moved this from Backlog to Done in [DEPRECATED] Mobile SDKs Jun 5, 2024
@krystofwoldrich krystofwoldrich self-assigned this Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expo Issues related to Sentry React Native Expo support Platform: React-Native
Projects
Archived in project
Archived in project
Archived in project
Development

No branches or pull requests

7 participants