Skip to content

sentry-expo deprecations plans #3262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krystofwoldrich opened this issue Aug 31, 2023 · 14 comments
Closed

sentry-expo deprecations plans #3262

krystofwoldrich opened this issue Aug 31, 2023 · 14 comments
Labels
Expo Issues related to Sentry React Native Expo support Platform: React-Native

Comments

@krystofwoldrich
Copy link
Member

krystofwoldrich commented Aug 31, 2023

sentry-expo is not deprecated yet and fully supports the current React Native 0.72 but likely won't get any new features, those will be added to sentry-react-native. This issue summarizes the deprecation plans.

### In Progress
- [ ] https://github.com/getsentry/sentry-react-native/issues/2083
- [ ] https://github.com/expo/expo/pull/25810
- [ ] https://github.com/expo/expo/pull/25859
- [ ] https://github.com/getsentry/sentry-wizard/issues/498
- [ ] https://github.com/getsentry/sentry-react-native/pull/3465
- [ ] https://github.com/getsentry/sentry-react-native/pull/3466
### MVP to deprecate `sentry-expo`
- [x] Verify unhandled rejected promise tracking in Expo Go/Expo builds
- [ ] https://github.com/getsentry/sentry-react-native/pull/3391
- [x] Support Expo Go (rewrite frames, only JS)
- [ ] https://github.com/getsentry/sentry-react-native/issues/3394
- [ ] https://github.com/getsentry/sentry-react-native/issues/3101
- [ ] https://github.com/getsentry/sentry-react-native/issues/3393
- [ ] https://github.com/getsentry/sentry-react-native/issues/3081
### Docs updates
- [x] Add Expo OTA Update source maps upload to Sentry Docs
- [x] Add migration docs to Expo Docs
- [x] Add migration docs to Sentry Docs
- [ ] https://github.com/getsentry/sentry-docs/pull/8631
- [ ] https://github.com/expo/expo/pull/25712
- [x] https://github.com/expo/sentry-expo/pull/385
### Future expo features
- [ ] https://github.com/getsentry/sentry-react-native/issues/3646
- [ ] https://github.com/getsentry/sentry-react-native/issues/3363
- [ ] https://github.com/getsentry/sentry-react-native/issues/3210
- [ ] https://github.com/getsentry/sentry-react-native/issues/3647
- [ ] https://github.com/getsentry/sentry-react-native/issues/2947
- [ ] https://github.com/getsentry/sentry-wizard/issues/285
- [ ] https://github.com/getsentry/sentry-react-native/issues/3608

Not planned to be migrated

  • ExpoBareIntegration (frames rewrite will be migrated, for additional tags, extras, and other event data will be supplied guide on how can be added by users)
  • ExpoManagedIntegration (frames rewrite will be migrated, for additional tags, extras, and other event data will be supplied guide on how can be added by users)
  • Post publish hook config used to set Sentry org, project, and authToken (will be replaced by envs or new solution)

Internal Notion notes

@brentvatne
Copy link
Contributor

thanks for putting this together and for the help here @krystofwoldrich! only feedback I have is re: Expo managed frames / Expo bare frames - those names in our sentry-expo repo are kind of misleading so I'll attempt to clarify that here:

the "Expo managed" integration should be called "Expo Go" (this app is a sandbox for learning/experimenting, I think even supporting it in Sentry is optional and I wouldn't be opposed to dropping that)

the "Expo bare" integration could just be called "Expo" (any app with the Expo SDK installed will work the same, no need to differentiate between managed or bare)

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Sep 26, 2023
@krystofwoldrich
Copy link
Member Author

@brentvatne Thank you for the context, I agree "Expo Go" is a lower priority (as Sentry is oriented on production bugs), but to keep a good dev experience, we would like the JS error captured during development in Expo Go to be correctly reported (source mapped) in Sentry.

@getsantry getsantry bot removed the status in GitHub Issues with 👀 Sep 28, 2023
@krystofwoldrich krystofwoldrich moved this from In Progress to Todo in [DEPRECATED] Mobile SDKs Oct 9, 2023
@krystofwoldrich krystofwoldrich removed their assignment Oct 9, 2023
@shanamatthews
Copy link

Hey @krystofwoldrich - I'm assuming this will need at least a small docs change to the Expo section of docs. Just want to make sure that's it!

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Oct 12, 2023
@krystofwoldrich
Copy link
Member Author

@shanamatthews Yes, this will need a few changes in the docs, not only the Expo section but also a migration guide from the sentry-expo package to sentry-react-native.

@felix-lambert
Copy link

felix-lambert commented Nov 10, 2023

@krystofwoldrich Hello the sourcemap is still not being uploaded. Can we have instruction on how to upload the sourcemap with sentry? On older version of expo I didn't have this problem. It has now been a few months i'm using expo and sentry without sourcemaps. The sourcemap seems to upload well on the web app version but not on android or ios :)

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Nov 10, 2023
@krystofwoldrich
Copy link
Member Author

krystofwoldrich commented Nov 14, 2023

@felix-lambert Hi, thank you for the message, could you share what Sentry SDK version and Expo version are you using and how you build the app?

The auto upload was fixed in the latest release of https://github.com/expo/sentry-expo/releases/tag/v7.1.1.

@felix-lambert
Copy link

felix-lambert commented Nov 16, 2023

I tried the latest release and it has been fixed. The sourcemap seems to upload well to sentry on android and ios now. Well done ! :)

@krystofwoldrich
Copy link
Member Author

@sentry/react-native now supports Expo out of the box!

Update to https://github.com/getsentry/sentry-react-native/releases/tag/5.16.0 or newer to get all the new features.

Migration guides available:

@github-project-automation github-project-automation bot moved this from Needs Review to Done in [DEPRECATED] Mobile SDKs Feb 29, 2024
@natasxa
Copy link

natasxa commented Mar 10, 2024

Can you help me with the error: "PluginError: Failed to resolve plugin for module "@sentry/react-native/expo" ..."
Updated app to expo SDK 50 and now trying to update sentry-expo to @sentry/react-native...

@paulmthiebauth
Copy link

paulmthiebauth commented Mar 15, 2024

Can you help me with the error: "PluginError: Failed to resolve plugin for module "@sentry/react-native/expo" ..." Updated app to expo SDK 50 and now trying to update sentry-expo to @sentry/react-native...

Dealing with the same error right now trying to upgrade SDK. Added entry to plugins in app.config.ts as the migration guide says is fine

@brentvatne
Copy link
Contributor

@natasxa @paulmthiebauth - do you have @sentry/react-native installed in your project? which version?

@natasxa
Copy link

natasxa commented Mar 17, 2024

@brentvatne sure I do, "@sentry/react-native": "5.10.0"

@jmacbhc
Copy link

jmacbhc commented Oct 23, 2024

Can you help me with the error: "PluginError: Failed to resolve plugin for module "@sentry/react-native/expo" ..." Updated app to expo SDK 50 and now trying to update sentry-expo to @sentry/react-native...

I am getting the same error while running npx expo-doctor@latest

@zowebs
Copy link

zowebs commented Nov 7, 2024

Can you help me with the error: "PluginError: Failed to resolve plugin for module "@sentry/react-native/expo" ..." Updated app to expo SDK 50 and now trying to update sentry-expo to @sentry/react-native...

I am getting the same error while running npx expo-doctor@latest

I've got the same problem. Getting this error after running npx expo-doctor@latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Expo Issues related to Sentry React Native Expo support Platform: React-Native
Projects
Archived in project
Archived in project
Development

No branches or pull requests

9 participants