-
-
Notifications
You must be signed in to change notification settings - Fork 344
sentry-expo
deprecations plans
#3262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
thanks for putting this together and for the help here @krystofwoldrich! only feedback I have is re: Expo managed frames / Expo bare frames - those names in our sentry-expo repo are kind of misleading so I'll attempt to clarify that here: the "Expo managed" integration should be called "Expo Go" (this app is a sandbox for learning/experimenting, I think even supporting it in Sentry is optional and I wouldn't be opposed to dropping that) the "Expo bare" integration could just be called "Expo" (any app with the Expo SDK installed will work the same, no need to differentiate between managed or bare) |
@brentvatne Thank you for the context, I agree "Expo Go" is a lower priority (as Sentry is oriented on production bugs), but to keep a good dev experience, we would like the JS error captured during development in Expo Go to be correctly reported (source mapped) in Sentry. |
Hey @krystofwoldrich - I'm assuming this will need at least a small docs change to the Expo section of docs. Just want to make sure that's it! |
@shanamatthews Yes, this will need a few changes in the docs, not only the Expo section but also a migration guide from the |
@krystofwoldrich Hello the sourcemap is still not being uploaded. Can we have instruction on how to upload the sourcemap with sentry? On older version of expo I didn't have this problem. It has now been a few months i'm using expo and sentry without sourcemaps. The sourcemap seems to upload well on the web app version but not on android or ios :) |
@felix-lambert Hi, thank you for the message, could you share what Sentry SDK version and Expo version are you using and how you build the app? The auto upload was fixed in the latest release of https://github.com/expo/sentry-expo/releases/tag/v7.1.1. |
I tried the latest release and it has been fixed. The sourcemap seems to upload well to sentry on android and ios now. Well done ! :) |
Update to https://github.com/getsentry/sentry-react-native/releases/tag/5.16.0 or newer to get all the new features. Migration guides available: |
Can you help me with the error: "PluginError: Failed to resolve plugin for module "@sentry/react-native/expo" ..." |
Dealing with the same error right now trying to upgrade SDK. Added entry to |
@natasxa @paulmthiebauth - do you have |
@brentvatne sure I do, "@sentry/react-native": "5.10.0" |
I am getting the same error while running npx expo-doctor@latest |
I've got the same problem. Getting this error after running |
sentry-expo
is not deprecated yet and fully supports the current React Native 0.72 but likely won't get any new features, those will be added tosentry-react-native
. This issue summarizes the deprecation plans.Not planned to be migrated
Internal Notion notes
The text was updated successfully, but these errors were encountered: