Skip to content

Don't mark native apply methods as in-app in Expo apps #3286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
krystofwoldrich opened this issue Sep 18, 2023 · 3 comments
Closed

Don't mark native apply methods as in-app in Expo apps #3286

krystofwoldrich opened this issue Sep 18, 2023 · 3 comments
Assignees
@lucas-zimerman
Labels
Expo Issues related to Sentry React Native Expo support Platform: React-Native

Comments

@krystofwoldrich
Copy link
Member

Description

Sentry expo rewrite frames integration is modifying some native frames which causes them to be marked as in-app.

sentry-expo https://github.com/expo/sentry-expo/blob/main/src/sentry.ts#L91

Fix from sentry-react-native

sentry-react-native/src/js/integrations/rewriteframes.ts

Line 35 in 4cc74aa

if (frame.filename === '[native code]' || frame.filename === 'native') {

@github-project-automation github-project-automation bot moved this to Needs Discussion in [DEPRECATED] Mobile SDKs Sep 18, 2023
@krystofwoldrich krystofwoldrich moved this from Needs Discussion to Backlog in [DEPRECATED] Mobile SDKs Sep 22, 2023
@krystofwoldrich krystofwoldrich added Breaking-change should go in a major release (breaks apps, changes default configs in a major way) and removed Breaking-change should go in a major release (breaks apps, changes default configs in a major way) labels Dec 15, 2023
@kahest kahest added Expo Issues related to Sentry React Native Expo support and removed sentry-expo labels Jan 26, 2024
@lucas-zimerman lucas-zimerman moved this from Backlog to In Progress in [DEPRECATED] Mobile SDKs Nov 14, 2024
@lucas-zimerman
Copy link
Collaborator

@krystofwoldrich sentry expo didn't receive any updates in a while, is this issue still needed?

@lucas-zimerman lucas-zimerman moved this from In Progress to Needs Discussion in [DEPRECATED] Mobile SDKs Nov 15, 2024
@krystofwoldrich
Copy link
Member Author

@lucas-zimerman Thanks, yes sentry-expo is deprecated and should not be used anymore.

@krystofwoldrich
Copy link
Member Author

Since Expo SDK 50 @sentry/react-native replaces sentry-expo.

https://docs.sentry.io/platforms/react-native/migration/sentry-expo/

@krystofwoldrich krystofwoldrich closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
@github-project-automation github-project-automation bot moved this from Needs Discussion to Done in [DEPRECATED] Mobile SDKs Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucas-zimerman lucas-zimerman

Labels
Expo Issues related to Sentry React Native Expo support Platform: React-Native
Projects
[DEPRECATED] Mobile SDKs
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kahest @lucas-zimerman @krystofwoldrich