Skip to content

Bump android SDK to 6.19.0 & set native SDK name #3086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 24, 2023
Merged

Bump android SDK to 6.19.0 & set native SDK name #3086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc77242
bump android SDK to 1.19.0 & set native SDK name
lucas-zimerman May 23, 2023
ec784c5
update changelog.
lucas-zimerman May 23, 2023
e4b1bd2
Use const parameter
lucas-zimerman May 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
- Bump JavaScript SDK from v7.52.0 to v7.52.1 ([#3071](https://github.com/getsentry/sentry-react-native/pull/3071))
- [changelog](https://github.com/getsentry/sentry-javascript/blob/develop/CHANGELOG.md#7521)
- [diff](https://github.com/getsentry/sentry-javascript/compare/7.52.0...7.52.1)
- Bump Android SDK from v6.18.1 to v6.19.0 ([#3086](https://github.com/getsentry/sentry-react-native/pull/3086))
- [changelog](https://github.com/getsentry/sentry-java/blob/main/CHANGELOG.md#6190)
- [diff](https://github.com/getsentry/sentry-java/compare/6.18.1...6.19.0)

## 5.5.0

Expand Down
2 changes: 1 addition & 1 deletion android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,5 +42,5 @@ android {

dependencies {
implementation 'com.facebook.react:react-native:+'
api 'io.sentry:sentry-android:6.18.1'
api 'io.sentry:sentry-android:6.19.0'
}
3 changes: 2 additions & 1 deletion android/src/main/java/io/sentry/react/RNSentryModuleImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ public class RNSentryModuleImpl {

public static final String NAME = "RNSentry";

private static final String NATIVE_SDK_NAME = "sentry.native.android";
private static final String NATIVE_SDK_NAME = "sentry.native.android.react-native";
private static final String ANDROID_SDK_NAME = "sentry.java.android.react-native";
private static final ILogger logger = new AndroidLogger(NAME);
private static final BuildInfoProvider buildInfo = new BuildInfoProvider(logger);
Expand Down Expand Up @@ -113,6 +113,7 @@ public void initNativeSdk(final ReadableMap rnOptions, Promise promise) {
}

options.setSentryClientName(sdkVersion.getName() + "/" + sdkVersion.getVersion());
options.setNativeSdkName(NATIVE_SDK_NAME);
options.setSdkVersion(sdkVersion);

if (rnOptions.hasKey("debug") && rnOptions.getBoolean("debug")) {
Expand Down