feat(android): Add enableNdk to rn options

[krystofwoldrich]

📢 Type of change

• New feature

📜 Description

This PR adds an option to disable/enable the sentry native on Android. This should help users experiencing https://issuetracker.google.com/issues/300840851 until resolved.

💡 Motivation and Context

• Android App crashing after Google Play System August update facebook/react-native#39505
• https://getsentry.atlassian.net/browse/INC-517
• https://issuetracker.google.com/issues/300840851

💚 How did you test it?

ci

📝 Checklist

• I reviewed submitted code
• I added tests to verify changes
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
• All tests passing
• No breaking changes

🔮 Next steps

[github-actions]

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c9d17a1

[github-actions]

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1253.72 ms	1274.00 ms	20.28 ms
Size	2.92 MiB	3.43 MiB	524.64 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
d197b5c+dirty	1234.80 ms	1249.20 ms	14.40 ms
15c80ab+dirty	1248.41 ms	1251.24 ms	2.83 ms
0db0c72+dirty	1258.88 ms	1262.52 ms	3.64 ms
d0bf494+dirty	1266.20 ms	1267.52 ms	1.32 ms
52a8031+dirty	1255.96 ms	1273.00 ms	17.04 ms
70caa60+dirty	1279.08 ms	1281.54 ms	2.46 ms
e5c9b8b+dirty	1276.90 ms	1280.92 ms	4.02 ms
b1e8712+dirty	1284.11 ms	1297.82 ms	13.71 ms
acadc0f+dirty	1271.12 ms	1272.28 ms	1.16 ms
0677344+dirty	1252.52 ms	1254.08 ms	1.56 ms

App size

Revision	Plain	With Sentry	Diff
d197b5c+dirty	2.92 MiB	3.37 MiB	464.41 KiB
15c80ab+dirty	2.92 MiB	3.39 MiB	481.56 KiB
0db0c72+dirty	2.92 MiB	3.40 MiB	492.71 KiB
d0bf494+dirty	2.92 MiB	3.40 MiB	488.08 KiB
52a8031+dirty	2.92 MiB	3.38 MiB	475.71 KiB
70caa60+dirty	2.92 MiB	3.39 MiB	486.04 KiB
e5c9b8b+dirty	2.92 MiB	3.43 MiB	524.50 KiB
b1e8712+dirty	2.92 MiB	3.40 MiB	494.15 KiB
acadc0f+dirty	2.92 MiB	3.39 MiB	487.34 KiB
0677344+dirty	2.92 MiB	3.41 MiB	500.94 KiB

[github-actions]

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	291.73 ms	363.74 ms	72.01 ms
Size	7.15 MiB	8.10 MiB	980.91 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
d197b5c+dirty	258.75 ms	313.61 ms	54.86 ms
15c80ab+dirty	276.38 ms	327.54 ms	51.17 ms
0db0c72+dirty	335.20 ms	351.06 ms	15.86 ms
d0bf494+dirty	253.73 ms	308.23 ms	54.49 ms
52a8031+dirty	330.72 ms	358.76 ms	28.03 ms
70caa60+dirty	308.83 ms	393.06 ms	84.23 ms
e5c9b8b+dirty	335.40 ms	360.06 ms	24.67 ms
b1e8712+dirty	322.55 ms	331.84 ms	9.29 ms
acadc0f+dirty	259.04 ms	304.67 ms	45.63 ms
0677344+dirty	288.40 ms	391.44 ms	103.04 ms

App size

Revision	Plain	With Sentry	Diff
d197b5c+dirty	7.15 MiB	8.09 MiB	962.72 KiB
15c80ab+dirty	7.15 MiB	8.09 MiB	966.13 KiB
0db0c72+dirty	7.15 MiB	8.04 MiB	911.02 KiB
d0bf494+dirty	7.15 MiB	8.04 MiB	910.85 KiB
52a8031+dirty	7.15 MiB	8.09 MiB	965.95 KiB
70caa60+dirty	7.15 MiB	8.03 MiB	901.79 KiB
e5c9b8b+dirty	7.15 MiB	8.10 MiB	980.41 KiB
b1e8712+dirty	7.15 MiB	8.04 MiB	912.27 KiB
acadc0f+dirty	7.15 MiB	8.03 MiB	903.20 KiB
0677344+dirty	7.15 MiB	8.07 MiB	949.80 KiB

[github-actions]

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	394.55 ms	416.77 ms	22.22 ms
Size	17.73 MiB	19.83 MiB	2.10 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
d197b5c+dirty	338.94 ms	354.87 ms	15.93 ms
15c80ab+dirty	336.27 ms	350.58 ms	14.31 ms
e5c9b8b	409.02 ms	426.66 ms	17.64 ms
abb7058	370.27 ms	389.58 ms	19.31 ms
0db0c72	372.12 ms	386.00 ms	13.88 ms
d0bf494+dirty	375.37 ms	395.14 ms	19.77 ms
52a8031+dirty	311.55 ms	321.37 ms	9.82 ms
70caa60+dirty	299.00 ms	321.02 ms	22.02 ms
3ffcddd	302.92 ms	315.80 ms	12.88 ms
acadc0f+dirty	373.24 ms	381.51 ms	8.27 ms

App size

Revision	Plain	With Sentry	Diff
d197b5c+dirty	17.73 MiB	20.04 MiB	2.31 MiB
15c80ab+dirty	17.73 MiB	20.04 MiB	2.31 MiB
e5c9b8b	17.73 MiB	19.83 MiB	2.10 MiB
abb7058	17.73 MiB	19.83 MiB	2.10 MiB
0db0c72	17.73 MiB	19.75 MiB	2.02 MiB
d0bf494+dirty	17.73 MiB	19.75 MiB	2.02 MiB
52a8031+dirty	17.73 MiB	20.04 MiB	2.31 MiB
70caa60+dirty	17.73 MiB	19.75 MiB	2.01 MiB
3ffcddd	17.73 MiB	19.75 MiB	2.02 MiB
acadc0f+dirty	17.73 MiB	19.75 MiB	2.01 MiB

[github-actions]

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1243.44 ms	1269.50 ms	26.06 ms
Size	2.36 MiB	2.87 MiB	520.55 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
d197b5c+dirty	1217.61 ms	1242.66 ms	25.05 ms
15c80ab+dirty	1223.74 ms	1228.96 ms	5.22 ms
0db0c72+dirty	1275.02 ms	1285.84 ms	10.82 ms
d0bf494+dirty	1289.40 ms	1298.40 ms	9.00 ms
52a8031+dirty	1280.88 ms	1289.78 ms	8.90 ms
70caa60+dirty	1218.27 ms	1230.30 ms	12.03 ms
e5c9b8b+dirty	1258.57 ms	1267.32 ms	8.75 ms
b1e8712+dirty	1256.02 ms	1265.14 ms	9.12 ms
acadc0f+dirty	1264.38 ms	1290.06 ms	25.68 ms
0677344+dirty	1276.70 ms	1300.07 ms	23.37 ms

App size

Revision	Plain	With Sentry	Diff
d197b5c+dirty	2.36 MiB	2.82 MiB	462.86 KiB
15c80ab+dirty	2.36 MiB	2.83 MiB	474.49 KiB
0db0c72+dirty	2.36 MiB	2.84 MiB	487.01 KiB
d0bf494+dirty	2.36 MiB	2.83 MiB	481.15 KiB
52a8031+dirty	2.36 MiB	2.82 MiB	469.44 KiB
70caa60+dirty	2.36 MiB	2.83 MiB	479.27 KiB
e5c9b8b+dirty	2.36 MiB	2.87 MiB	520.43 KiB
b1e8712+dirty	2.36 MiB	2.84 MiB	488.84 KiB
acadc0f+dirty	2.36 MiB	2.83 MiB	480.37 KiB
0677344+dirty	2.36 MiB	2.85 MiB	496.81 KiB

[romtsn]

lgtm! we also have protection mechanism to disable the scope sync when the whole integration is disabled https://github.com/getsentry/sentry-java/blob/8d29d97f110f18b538dcee5ab066b08a9b04c749/sentry-android-core/src/main/java/io/sentry/android/core/NdkIntegration.java#L71-L74

[TheRogue76]

Bless y'all. This has been a nightmare to track for the past 2 weeks.

[fabiendem]

Hi @krystofwoldrich, sorry could you clarify if we're supposed to turn this flag off or on to prevent the issue from happening?
I have read the Google Issue track thread and didn't get the info there.
Is the default value you're setting enough?