Skip to content

feat(xcode): Dynamically resolve SDK and CLI package paths #3431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Dec 4, 2023

Conversation

krystofwoldrich
Copy link
Member

@krystofwoldrich krystofwoldrich commented Nov 28, 2023

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Dynamically resolve SDK and CLI package paths ([#3431](https://github.com/getsentry/sentry-react-native/pull/3431))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 00eb25d

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 420.57 ms 463.56 ms 42.99 ms
Size 17.73 MiB 19.84 MiB 2.11 MiB

Previous results on branch: kw-update-plugin

Startup times

Revision Plain With Sentry Diff
a859804 610.00 ms 674.14 ms 64.14 ms
c6d89fb 408.90 ms 453.71 ms 44.82 ms

App size

Revision Plain With Sentry Diff
a859804 17.73 MiB 19.84 MiB 2.11 MiB
c6d89fb 17.73 MiB 19.84 MiB 2.11 MiB

Copy link
Contributor

github-actions bot commented Nov 28, 2023

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1289.54 ms 1298.96 ms 9.42 ms
Size 2.92 MiB 3.43 MiB 524.98 KiB

Previous results on branch: kw-update-plugin

Startup times

Revision Plain With Sentry Diff
c6d89fb+dirty 1220.88 ms 1224.61 ms 3.73 ms
a859804+dirty 1224.46 ms 1227.31 ms 2.85 ms

App size

Revision Plain With Sentry Diff
c6d89fb+dirty 2.92 MiB 3.43 MiB 524.98 KiB
a859804+dirty 2.92 MiB 3.43 MiB 524.93 KiB

Copy link
Contributor

github-actions bot commented Nov 28, 2023

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 381.59 ms 453.06 ms 71.47 ms
Size 7.15 MiB 8.11 MiB 987.05 KiB

Previous results on branch: kw-update-plugin

Startup times

Revision Plain With Sentry Diff
c6d89fb+dirty 406.08 ms 462.51 ms 56.43 ms
a859804+dirty 392.09 ms 462.82 ms 70.73 ms

App size

Revision Plain With Sentry Diff
c6d89fb+dirty 7.15 MiB 8.11 MiB 987.05 KiB
a859804+dirty 7.15 MiB 8.11 MiB 987.05 KiB

Copy link
Contributor

github-actions bot commented Nov 28, 2023

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1235.29 ms 1242.52 ms 7.23 ms
Size 2.36 MiB 2.87 MiB 521.02 KiB

Previous results on branch: kw-update-plugin

Startup times

Revision Plain With Sentry Diff
c6d89fb+dirty 1223.85 ms 1228.27 ms 4.42 ms
a859804+dirty 1205.02 ms 1212.18 ms 7.16 ms

App size

Revision Plain With Sentry Diff
c6d89fb+dirty 2.36 MiB 2.87 MiB 521.07 KiB
a859804+dirty 2.36 MiB 2.87 MiB 521.00 KiB

Base automatically changed from kw-add-expo-namespace to expo November 29, 2023 09:10
@krystofwoldrich krystofwoldrich marked this pull request as ready for review December 1, 2023 16:48
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we should add this to the changelog, but other than that, LGTM!

@krystofwoldrich krystofwoldrich merged commit 62320b4 into expo Dec 4, 2023
@krystofwoldrich krystofwoldrich deleted the kw-update-plugin branch December 4, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants