-
-
Notifications
You must be signed in to change notification settings - Fork 344
feat(xcode): Dynamically resolve SDK and CLI package paths #3431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…monorepo friendly
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Dynamically resolve SDK and CLI package paths ([#3431](https://github.com/getsentry/sentry-react-native/pull/3431)) If none of the above apply, you can opt out of this check by adding |
Android (legacy) Performance metrics 🚀
|
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c6d89fb+dirty | 1220.88 ms | 1224.61 ms | 3.73 ms |
a859804+dirty | 1224.46 ms | 1227.31 ms | 2.85 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c6d89fb+dirty | 2.92 MiB | 3.43 MiB | 524.98 KiB |
a859804+dirty | 2.92 MiB | 3.43 MiB | 524.93 KiB |
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c6d89fb+dirty | 406.08 ms | 462.51 ms | 56.43 ms |
a859804+dirty | 392.09 ms | 462.82 ms | 70.73 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c6d89fb+dirty | 7.15 MiB | 8.11 MiB | 987.05 KiB |
a859804+dirty | 7.15 MiB | 8.11 MiB | 987.05 KiB |
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c6d89fb+dirty | 1223.85 ms | 1228.27 ms | 4.42 ms |
a859804+dirty | 1205.02 ms | 1212.18 ms | 7.16 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c6d89fb+dirty | 2.36 MiB | 2.87 MiB | 521.07 KiB |
a859804+dirty | 2.36 MiB | 2.87 MiB | 521.00 KiB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we should add this to the changelog, but other than that, LGTM!
📢 Type of change
📜 Description
💡 Motivation and Context
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps