Skip to content

fix(sample): All Expo native scripts paths are relative to the repo root #3461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 13, 2023
Merged

fix(sample): All Expo native scripts paths are relative to the repo root #3461

merged 2 commits into from
Dec 13, 2023

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix

📜 Description

The Expo sample native builds didn't work due to incorrect paths.

💚 How did you test it?

build locally

e2e test will be added in a follow-up PR.

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

#skip-changelog

@github-actions GitHub Actions
Copy link
Contributor

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 411.92 ms 433.08 ms 21.16 ms
Size 17.73 MiB 19.84 MiB 2.11 MiB

@github-actions GitHub Actions
Copy link
Contributor

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1207.96 ms 1210.49 ms 2.53 ms
Size 2.92 MiB 3.43 MiB 528.44 KiB

@github-actions GitHub Actions
Copy link
Contributor

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 339.88 ms 375.30 ms 35.42 ms
Size 7.15 MiB 8.11 MiB 988.28 KiB

lucas-zimerman
lucas-zimerman approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krystofwoldrich krystofwoldrich merged commit a788595 into expo Dec 13, 2023
@krystofwoldrich krystofwoldrich deleted the kw-local-plugin-to-expo-sample branch December 13, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krystofwoldrich @lucas-zimerman