Skip to content

feat(expo): Add npx sentry-expo-upload-sourcemaps command #3510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

krystofwoldrich
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR fixes the missing script file in the published package. And adds npx command for simple execution of the upload script.

💚 How did you test it?

sample app

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 5182eff

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 428.90 ms 453.26 ms 24.36 ms
Size 17.73 MiB 19.84 MiB 2.11 MiB

Baseline results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b 419.25 ms 458.81 ms 39.56 ms

App size

Revision Plain With Sentry Diff
bc4097b 17.73 MiB 19.84 MiB 2.11 MiB

Copy link
Contributor

github-actions bot commented Jan 9, 2024

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1236.58 ms 1244.98 ms 8.40 ms
Size 2.92 MiB 3.43 MiB 530.11 KiB

Baseline results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b+dirty 1229.02 ms 1235.65 ms 6.63 ms

App size

Revision Plain With Sentry Diff
bc4097b+dirty 2.92 MiB 3.43 MiB 528.75 KiB

@krystofwoldrich krystofwoldrich merged commit 0d87adb into expo Jan 9, 2024
@krystofwoldrich krystofwoldrich deleted the kw-add-npx-commnad-for-expo-upload branch January 9, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants