Skip to content

feat: touch breadcrumbs info improvements #3899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jun 25, 2024
Merged

feat: touch breadcrumbs info improvements #3899

merged 8 commits into from
Jun 25, 2024

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Jun 18, 2024 •
edited
Loading

  • cleanup & fix touchevent ignore behaviour
  • feat: support annotated components in touch events
  • deduplicate subsequent items in the component tree/path

Example event: https://sentry-sdks.sentry.io/issues/5502756331/events/13026ba7f65a4eab8ec5dfd835c11888/
image

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 18, 2024 •
edited
Loading

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against d64fbbb

@vaind vaind force-pushed the feat/touch-compoment-improvements branch from a8fd9e1 to b063a5e Compare June 18, 2024 11:26
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 18, 2024 •
edited
Loading

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1208.04 ms 1204.46 ms -3.58 ms
Size 2.36 MiB 3.04 MiB 696.39 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms
457e29f+dirty 1253.94 ms 1269.18 ms 15.24 ms
62a750b+dirty 1216.60 ms 1229.14 ms 12.54 ms
e73f4ed+dirty 1243.27 ms 1244.52 ms 1.25 ms
5571a20+dirty 1203.57 ms 1204.57 ms 1.00 ms
d0bf494+dirty 1289.40 ms 1298.40 ms 9.00 ms
f06c879+dirty 1252.64 ms 1259.66 ms 7.02 ms
2534337+dirty 1225.08 ms 1230.26 ms 5.17 ms

App size

Revision Plain With Sentry Diff
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB
457e29f+dirty 2.36 MiB 2.87 MiB 520.67 KiB
62a750b+dirty 2.36 MiB 2.92 MiB 570.00 KiB
e73f4ed+dirty 2.36 MiB 2.82 MiB 469.44 KiB
5571a20+dirty 2.36 MiB 2.92 MiB 569.93 KiB
d0bf494+dirty 2.36 MiB 2.83 MiB 481.15 KiB
f06c879+dirty 2.36 MiB 2.88 MiB 530.42 KiB
2534337+dirty 2.36 MiB 2.88 MiB 525.47 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 18, 2024 •
edited
Loading

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 316.84 ms 348.30 ms 31.46 ms
Size 7.15 MiB 8.22 MiB 1.07 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
12427f4+dirty 379.48 ms 400.92 ms 21.44 ms
80b2ce3+dirty 271.29 ms 316.47 ms 45.18 ms
15c80ab+dirty 276.38 ms 327.54 ms 51.17 ms
5bb8d5f+dirty 356.71 ms 389.65 ms 32.94 ms
9c48b2c+dirty 270.82 ms 321.12 ms 50.30 ms
457e29f+dirty 591.49 ms 612.96 ms 21.47 ms
62a750b+dirty 370.78 ms 376.73 ms 5.96 ms
148f924+dirty 347.36 ms 389.13 ms 41.77 ms
5a22220+dirty 384.61 ms 419.06 ms 34.45 ms
6e8584e+dirty 383.37 ms 400.84 ms 17.47 ms

App size

Revision Plain With Sentry Diff
12427f4+dirty 7.15 MiB 8.12 MiB 997.78 KiB
80b2ce3+dirty 7.15 MiB 8.04 MiB 911.02 KiB
15c80ab+dirty 7.15 MiB 8.09 MiB 966.13 KiB
5bb8d5f+dirty 7.15 MiB 8.21 MiB 1.06 MiB
9c48b2c+dirty 7.15 MiB 8.07 MiB 947.16 KiB
457e29f+dirty 7.15 MiB 8.10 MiB 981.29 KiB
62a750b+dirty 7.15 MiB 8.21 MiB 1.06 MiB
148f924+dirty 7.15 MiB 8.21 MiB 1.07 MiB
5a22220+dirty 7.15 MiB 8.21 MiB 1.06 MiB
6e8584e+dirty 7.15 MiB 8.13 MiB 1002.18 KiB

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 18, 2024 •
edited
Loading

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 396.56 ms 433.51 ms 36.95 ms
Size 17.73 MiB 19.94 MiB 2.21 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
1d86dd6 405.14 ms 411.06 ms 5.92 ms
f06c879 408.41 ms 424.54 ms 16.13 ms
22e31b6 396.48 ms 419.64 ms 23.16 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
d361d38 354.10 ms 381.69 ms 27.59 ms
12427f4 393.69 ms 414.84 ms 21.14 ms
5bb8d5f 431.21 ms 459.40 ms 28.19 ms
9c48b2c 349.24 ms 385.96 ms 36.72 ms
b1e8712 462.11 ms 465.71 ms 3.60 ms
d0bf494+dirty 375.37 ms 395.14 ms 19.77 ms

App size

Revision Plain With Sentry Diff
1d86dd6 17.73 MiB 19.86 MiB 2.12 MiB
f06c879 17.73 MiB 19.85 MiB 2.12 MiB
22e31b6 17.73 MiB 19.84 MiB 2.10 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
d361d38 17.73 MiB 19.81 MiB 2.08 MiB
12427f4 17.73 MiB 19.85 MiB 2.12 MiB
5bb8d5f 17.73 MiB 19.93 MiB 2.20 MiB
9c48b2c 17.73 MiB 19.80 MiB 2.07 MiB
b1e8712 17.73 MiB 19.75 MiB 2.02 MiB
d0bf494+dirty 17.73 MiB 19.75 MiB 2.02 MiB

@vaind vaind marked this pull request as ready for review June 18, 2024 13:20
@vaind vaind requested a review from lucas-zimerman as a code owner June 18, 2024 13:20
@vaind vaind mentioned this pull request Jun 18, 2024
Merged
4 tasks
lucas-zimerman
lucas-zimerman reviewed Jun 20, 2024
View reviewed changes
@vaind @lucas-zimerman
Update CHANGELOG.md
f7d9a35 
Co-authored-by: LucasZF <[email protected]>
krystofwoldrich
krystofwoldrich reviewed Jun 25, 2024
View reviewed changes
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024 •
edited
Loading

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1206.27 ms 1215.53 ms 9.26 ms
Size 2.92 MiB 3.60 MiB 702.01 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
9c48b2c+dirty 1253.39 ms 1256.30 ms 2.91 ms
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms
3853f43+dirty 1271.74 ms 1278.04 ms 6.30 ms
457e29f+dirty 1256.71 ms 1258.50 ms 1.79 ms
62a750b+dirty 1228.12 ms 1230.53 ms 2.41 ms
e73f4ed+dirty 1282.90 ms 1309.30 ms 26.40 ms
5571a20+dirty 1228.09 ms 1233.45 ms 5.36 ms
d0bf494+dirty 1266.20 ms 1267.52 ms 1.32 ms
f06c879+dirty 1285.14 ms 1285.86 ms 0.72 ms
2534337+dirty 1220.87 ms 1221.47 ms 0.60 ms

App size

Revision Plain With Sentry Diff
9c48b2c+dirty 2.92 MiB 3.41 MiB 499.97 KiB
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB
3853f43+dirty 2.92 MiB 3.41 MiB 503.54 KiB
457e29f+dirty 2.92 MiB 3.43 MiB 524.75 KiB
62a750b+dirty 2.92 MiB 3.48 MiB 575.59 KiB
e73f4ed+dirty 2.92 MiB 3.38 MiB 475.71 KiB
5571a20+dirty 2.92 MiB 3.48 MiB 575.54 KiB
d0bf494+dirty 2.92 MiB 3.40 MiB 488.08 KiB
f06c879+dirty 2.92 MiB 3.44 MiB 533.24 KiB
2534337+dirty 2.92 MiB 3.43 MiB 529.76 KiB

krystofwoldrich
krystofwoldrich approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@vaind vaind merged commit 4a6664f into main Jun 25, 2024
60 checks passed
@vaind vaind deleted the feat/touch-compoment-improvements branch June 25, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucas-zimerman lucas-zimerman lucas-zimerman left review comments

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
[DEPRECATED] Mobile SDKs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaind @lucas-zimerman @krystofwoldrich