-
-
Notifications
You must be signed in to change notification settings - Fork 344
chore(deps): update JavaScript SDK to v8.40.0 #4304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
273168c
to
0482944
Compare
iOS (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
77680ec+dirty | 1231.81 ms | 1238.35 ms | 6.54 ms |
1faf8e3+dirty | 1214.87 ms | 1222.83 ms | 7.97 ms |
7bc4d75+dirty | 1233.40 ms | 1229.56 ms | -3.83 ms |
d7401ac+dirty | 1252.38 ms | 1275.04 ms | 22.66 ms |
8ae23a7+dirty | 1230.02 ms | 1227.62 ms | -2.40 ms |
5a22220+dirty | 1209.49 ms | 1220.94 ms | 11.45 ms |
80b2ce3+dirty | 1265.92 ms | 1268.60 ms | 2.69 ms |
b95b8af+dirty | 1221.39 ms | 1228.52 ms | 7.13 ms |
d0bf494+dirty | 1289.40 ms | 1298.40 ms | 9.00 ms |
f06c879+dirty | 1252.64 ms | 1259.66 ms | 7.02 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
77680ec+dirty | 2.36 MiB | 3.10 MiB | 753.42 KiB |
1faf8e3+dirty | 2.36 MiB | 3.08 MiB | 736.75 KiB |
7bc4d75+dirty | 2.36 MiB | 3.10 MiB | 752.58 KiB |
d7401ac+dirty | 2.36 MiB | 2.83 MiB | 481.14 KiB |
8ae23a7+dirty | 2.36 MiB | 3.10 MiB | 752.42 KiB |
5a22220+dirty | 2.36 MiB | 2.92 MiB | 570.21 KiB |
80b2ce3+dirty | 2.36 MiB | 2.84 MiB | 486.98 KiB |
b95b8af+dirty | 2.36 MiB | 3.14 MiB | 793.32 KiB |
d0bf494+dirty | 2.36 MiB | 2.83 MiB | 481.15 KiB |
f06c879+dirty | 2.36 MiB | 2.88 MiB | 530.42 KiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1e9894e+dirty | 1213.33 ms | 1225.16 ms | 11.83 ms |
f193e90+dirty | 1224.20 ms | 1229.10 ms | 4.90 ms |
e4c23be+dirty | 1225.25 ms | 1223.76 ms | -1.49 ms |
bca5c58+dirty | 1208.27 ms | 1212.41 ms | 4.14 ms |
4a9de34+dirty | 1215.58 ms | 1218.76 ms | 3.17 ms |
cdeca8b+dirty | 1212.42 ms | 1223.69 ms | 11.27 ms |
88a5c10+dirty | 1242.02 ms | 1249.54 ms | 7.52 ms |
d3ef7b9+dirty | 1232.10 ms | 1230.35 ms | -1.76 ms |
7871424+dirty | 1212.69 ms | 1224.40 ms | 11.72 ms |
c0332a6+dirty | 1223.13 ms | 1232.31 ms | 9.18 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1e9894e+dirty | 2.36 MiB | 3.10 MiB | 752.76 KiB |
f193e90+dirty | 2.36 MiB | 3.08 MiB | 737.28 KiB |
e4c23be+dirty | 2.36 MiB | 3.08 MiB | 737.17 KiB |
bca5c58+dirty | 2.36 MiB | 3.10 MiB | 752.95 KiB |
4a9de34+dirty | 2.36 MiB | 3.10 MiB | 753.19 KiB |
cdeca8b+dirty | 2.36 MiB | 3.09 MiB | 743.02 KiB |
88a5c10+dirty | 2.36 MiB | 3.10 MiB | 753.52 KiB |
d3ef7b9+dirty | 2.36 MiB | 3.10 MiB | 753.53 KiB |
7871424+dirty | 2.36 MiB | 3.10 MiB | 752.86 KiB |
c0332a6+dirty | 2.36 MiB | 3.08 MiB | 736.57 KiB |
iOS (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e73d82f+dirty | 1231.20 ms | 1228.81 ms | -2.40 ms |
d197b5c+dirty | 1234.80 ms | 1249.20 ms | 14.40 ms |
ac41368+dirty | 1226.69 ms | 1229.96 ms | 3.27 ms |
9cab16b+dirty | 1236.10 ms | 1247.16 ms | 11.06 ms |
8de2810+dirty | 1238.15 ms | 1236.31 ms | -1.84 ms |
7fd512a+dirty | 1239.41 ms | 1241.50 ms | 2.09 ms |
15c80ab+dirty | 1248.41 ms | 1251.24 ms | 2.83 ms |
8ae23a7+dirty | 1233.67 ms | 1229.52 ms | -4.15 ms |
0db0c72+dirty | 1258.88 ms | 1262.52 ms | 3.64 ms |
484813b+dirty | 1225.07 ms | 1221.00 ms | -4.07 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
e73d82f+dirty | 2.92 MiB | 3.64 MiB | 740.56 KiB |
d197b5c+dirty | 2.92 MiB | 3.37 MiB | 464.41 KiB |
ac41368+dirty | 2.92 MiB | 3.69 MiB | 794.29 KiB |
9cab16b+dirty | 2.92 MiB | 3.64 MiB | 743.06 KiB |
8de2810+dirty | 2.92 MiB | 3.66 MiB | 756.74 KiB |
7fd512a+dirty | 2.92 MiB | 3.66 MiB | 758.62 KiB |
15c80ab+dirty | 2.92 MiB | 3.39 MiB | 481.56 KiB |
8ae23a7+dirty | 2.92 MiB | 3.66 MiB | 757.67 KiB |
0db0c72+dirty | 2.92 MiB | 3.40 MiB | 492.71 KiB |
484813b+dirty | 2.92 MiB | 3.64 MiB | 740.56 KiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1e9894e+dirty | 1233.37 ms | 1226.96 ms | -6.41 ms |
f193e90+dirty | 1228.43 ms | 1229.02 ms | 0.59 ms |
e4c23be+dirty | 1232.21 ms | 1230.16 ms | -2.05 ms |
bca5c58+dirty | 1224.23 ms | 1224.90 ms | 0.66 ms |
4a9de34+dirty | 1234.35 ms | 1230.35 ms | -3.99 ms |
cdeca8b+dirty | 1235.78 ms | 1225.23 ms | -10.55 ms |
88a5c10+dirty | 1244.39 ms | 1238.30 ms | -6.09 ms |
d3ef7b9+dirty | 1228.35 ms | 1231.06 ms | 2.72 ms |
7871424+dirty | 1245.73 ms | 1235.39 ms | -10.35 ms |
c0332a6+dirty | 1227.13 ms | 1230.90 ms | 3.77 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
1e9894e+dirty | 2.92 MiB | 3.66 MiB | 757.26 KiB |
f193e90+dirty | 2.92 MiB | 3.64 MiB | 742.92 KiB |
e4c23be+dirty | 2.92 MiB | 3.64 MiB | 742.98 KiB |
bca5c58+dirty | 2.92 MiB | 3.66 MiB | 757.55 KiB |
4a9de34+dirty | 2.92 MiB | 3.66 MiB | 757.67 KiB |
cdeca8b+dirty | 2.92 MiB | 3.64 MiB | 744.52 KiB |
88a5c10+dirty | 2.92 MiB | 3.66 MiB | 758.74 KiB |
d3ef7b9+dirty | 2.92 MiB | 3.66 MiB | 758.76 KiB |
7871424+dirty | 2.92 MiB | 3.66 MiB | 757.21 KiB |
c0332a6+dirty | 2.92 MiB | 3.64 MiB | 742.47 KiB |
0482944
to
4b8b079
Compare
Android (new) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7fd512a+dirty | 439.69 ms | 503.71 ms | 64.01 ms |
0d3e677+dirty | 384.24 ms | 431.45 ms | 47.21 ms |
15c80ab+dirty | 276.38 ms | 327.54 ms | 51.17 ms |
0db0c72+dirty | 335.20 ms | 351.06 ms | 15.86 ms |
e2b64fe+dirty | 258.82 ms | 304.26 ms | 45.44 ms |
1c65324+dirty | 381.10 ms | 427.26 ms | 46.16 ms |
5a22220+dirty | 384.61 ms | 419.06 ms | 34.45 ms |
728164b+dirty | 335.93 ms | 342.94 ms | 7.01 ms |
62a750b+dirty | 370.78 ms | 376.73 ms | 5.96 ms |
c398f67+dirty | 315.08 ms | 345.60 ms | 30.52 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7fd512a+dirty | 7.15 MiB | 8.35 MiB | 1.21 MiB |
0d3e677+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
15c80ab+dirty | 7.15 MiB | 8.09 MiB | 966.13 KiB |
0db0c72+dirty | 7.15 MiB | 8.04 MiB | 911.02 KiB |
e2b64fe+dirty | 7.15 MiB | 8.07 MiB | 947.16 KiB |
1c65324+dirty | 7.15 MiB | 8.22 MiB | 1.07 MiB |
5a22220+dirty | 7.15 MiB | 8.21 MiB | 1.06 MiB |
728164b+dirty | 7.15 MiB | 8.12 MiB | 997.71 KiB |
62a750b+dirty | 7.15 MiB | 8.21 MiB | 1.06 MiB |
c398f67+dirty | 7.15 MiB | 8.21 MiB | 1.07 MiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bca5c58+dirty | 369.19 ms | 401.90 ms | 32.71 ms |
f193e90+dirty | 370.91 ms | 498.10 ms | 127.19 ms |
1e9894e+dirty | 385.63 ms | 420.18 ms | 34.55 ms |
7871424+dirty | 417.35 ms | 468.16 ms | 50.81 ms |
cdeca8b+dirty | 418.09 ms | 468.62 ms | 50.53 ms |
c0332a6+dirty | 389.21 ms | 449.39 ms | 60.17 ms |
4a9de34+dirty | 385.19 ms | 429.35 ms | 44.16 ms |
88a5c10+dirty | 387.13 ms | 438.66 ms | 51.53 ms |
e4c23be+dirty | 379.09 ms | 412.68 ms | 33.59 ms |
d3ef7b9+dirty | 388.12 ms | 435.53 ms | 47.41 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
bca5c58+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
f193e90+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
1e9894e+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
7871424+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
cdeca8b+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
c0332a6+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
4a9de34+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
88a5c10+dirty | 7.15 MiB | 8.36 MiB | 1.21 MiB |
e4c23be+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
d3ef7b9+dirty | 7.15 MiB | 8.36 MiB | 1.21 MiB |
4b8b079
to
a8633f2
Compare
antonis
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Android (legacy) Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c639edf | 466.48 ms | 489.57 ms | 23.09 ms |
ac41368 | 451.47 ms | 453.67 ms | 2.20 ms |
4cc5c27 | 460.04 ms | 496.32 ms | 36.28 ms |
62a750b | 395.96 ms | 423.36 ms | 27.41 ms |
dadc233+dirty | 333.78 ms | 343.94 ms | 10.16 ms |
2534337 | 394.15 ms | 415.12 ms | 20.97 ms |
8de2810 | 430.47 ms | 428.72 ms | -1.75 ms |
8900e1a+dirty | 430.68 ms | 456.13 ms | 25.44 ms |
7fd512a | 442.18 ms | 437.57 ms | -4.61 ms |
c398f67 | 449.64 ms | 461.38 ms | 11.74 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
c639edf | 17.74 MiB | 20.08 MiB | 2.34 MiB |
ac41368 | 17.73 MiB | 20.11 MiB | 2.38 MiB |
4cc5c27 | 17.73 MiB | 19.95 MiB | 2.21 MiB |
62a750b | 17.73 MiB | 19.93 MiB | 2.20 MiB |
dadc233+dirty | 17.73 MiB | 19.75 MiB | 2.02 MiB |
2534337 | 17.73 MiB | 19.84 MiB | 2.11 MiB |
8de2810 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
8900e1a+dirty | 17.73 MiB | 19.75 MiB | 2.01 MiB |
7fd512a | 17.74 MiB | 20.08 MiB | 2.35 MiB |
c398f67 | 17.73 MiB | 19.94 MiB | 2.21 MiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7871424 | 462.63 ms | 445.80 ms | -16.83 ms |
1e9894e | 431.94 ms | 445.06 ms | 13.12 ms |
4a9de34 | 423.00 ms | 429.66 ms | 6.66 ms |
88a5c10 | 425.60 ms | 414.21 ms | -11.39 ms |
bca5c58 | 498.31 ms | 498.32 ms | 0.01 ms |
d3ef7b9 | 486.60 ms | 474.76 ms | -11.84 ms |
cdeca8b | 438.11 ms | 436.48 ms | -1.63 ms |
e4c23be | 452.76 ms | 438.16 ms | -14.60 ms |
f193e90 | 432.83 ms | 433.10 ms | 0.27 ms |
c0332a6 | 461.40 ms | 456.00 ms | -5.40 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
7871424 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
1e9894e | 17.74 MiB | 20.08 MiB | 2.34 MiB |
4a9de34 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
88a5c10 | 17.74 MiB | 20.08 MiB | 2.35 MiB |
bca5c58 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
d3ef7b9 | 17.74 MiB | 20.08 MiB | 2.35 MiB |
cdeca8b | 17.74 MiB | 20.07 MiB | 2.34 MiB |
e4c23be | 17.74 MiB | 20.08 MiB | 2.34 MiB |
f193e90 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
c0332a6 | 17.74 MiB | 20.08 MiB | 2.34 MiB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps scripts/update-javascript.sh from 8.39.0 to 8.40.0.
Auto-generated by a dependency updater.
Changelog
8.40.0
Important Changes
feat(angular): Support Angular 19 (#14398)
The
sentry/angular
SDK can now be used with Angular 19. If you're upgrading to the new Angular version, you might want to migrate from the now deprecatedAPP_INITIALIZER
token toprovideAppInitializer
.In this case, change the Sentry
TraceService
initialization inapp.config.ts
:feat(core): Deprecate
debugIntegration
andsessionTimingIntegration
(#14363)The
debugIntegration
was deprecated and will be removed in the next major version of the SDK.To log outgoing events, use Hook Options (
beforeSend
,beforeSendTransaction
, ...).The
sessionTimingIntegration
was deprecated and will be removed in the next major version of the SDK.To capture session durations alongside events, use Context (
Sentry.setContext()
).feat(nestjs): Deprecate
WithSentry
in favor ofSentryExceptionCaptured
(#14323)The
WithSentry
decorator was deprecated. UseSentryExceptionCaptured
instead. This is a simple renaming and functionality stays identical.feat(nestjs): Deprecate
SentryTracingInterceptor
,SentryService
,SentryGlobalGenericFilter
,SentryGlobalGraphQLFilter
(#14371)The
SentryTracingInterceptor
was deprecated. If you are usingsentry/nestjs
you can safely remove any references to theSentryTracingInterceptor
. If you are using another package migrate tosentry/nestjs
and remove theSentryTracingInterceptor
afterwards.The
SentryService
was deprecated and its functionality was added toSentry.init
. If you are usingsentry/nestjs
you can safely remove any references to theSentryService
. If you are using another package migrate tosentry/nestjs
and remove theSentryService
afterwards.The
SentryGlobalGenericFilter
was deprecated. Use theSentryGlobalFilter
instead which is a drop-in replacement.The
SentryGlobalGraphQLFilter
was deprecated. Use theSentryGlobalFilter
instead which is a drop-in replacement.feat(node): Deprecate
nestIntegration
andsetupNestErrorHandler
in favor of usingsentry/nestjs
(#14374)The
nestIntegration
andsetupNestErrorHandler
functions fromsentry/node
were deprecated and will be removed in the next major version of the SDK. If you're usingsentry/node
in a NestJS application, we recommend switching to our new dedicatedsentry/nestjs
package.Other Changes
normalizedRequest
onsdkProcessingMetadata
is merged (#14315)sentry/utils
intosentry/core
(#14382)__self
and__source
attributes on feedback nodes (#14356)