Ref: Handle nested json configuration structures #4470
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 865c0d9 | 459.00 ms | 456.18 ms | -2.82 ms |
| 4ac2cff | 445.40 ms | 431.02 ms | -14.38 ms |
| 6a80f44 | 465.20 ms | 460.86 ms | -4.35 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 865c0d9 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| 4ac2cff | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| 6a80f44 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
Previous results on branch: antonis/ref-RNSentryJsonUtils
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 11c0bc5 | 419.08 ms | 454.54 ms | 35.46 ms |
| eff021d | 428.13 ms | 417.82 ms | -10.31 ms |
| f9a2e3c | 449.64 ms | 469.63 ms | 19.99 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 11c0bc5 | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| eff021d | 17.75 MiB | 20.11 MiB | 2.37 MiB |
| f9a2e3c | 17.75 MiB | 20.11 MiB | 2.37 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4ac2cff+dirty | 390.09 ms | 401.72 ms | 11.64 ms |
| 865c0d9+dirty | 342.12 ms | 366.85 ms | 24.73 ms |
| 6a80f44+dirty | 416.28 ms | 487.90 ms | 71.62 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 4ac2cff+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 865c0d9+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 6a80f44+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
Previous results on branch: antonis/ref-RNSentryJsonUtils
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f9a2e3c+dirty | 386.92 ms | 435.47 ms | 48.55 ms |
| 11c0bc5+dirty | 393.98 ms | 421.85 ms | 27.87 ms |
| eff021d+dirty | 404.96 ms | 469.09 ms | 64.13 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f9a2e3c+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| 11c0bc5+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
| eff021d+dirty | 7.15 MiB | 8.38 MiB | 1.23 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6a80f44+dirty | 1227.69 ms | 1227.96 ms | 0.26 ms |
| 865c0d9+dirty | 1218.47 ms | 1220.91 ms | 2.45 ms |
| 4ac2cff+dirty | 1209.27 ms | 1211.71 ms | 2.44 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6a80f44+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
| 865c0d9+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
| 4ac2cff+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
Previous results on branch: antonis/ref-RNSentryJsonUtils
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 11c0bc5+dirty | 1215.18 ms | 1217.63 ms | 2.45 ms |
| eff021d+dirty | 1233.80 ms | 1221.47 ms | -12.33 ms |
| f9a2e3c+dirty | 1230.61 ms | 1221.64 ms | -8.97 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 11c0bc5+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
| eff021d+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
| f9a2e3c+dirty | 2.63 MiB | 3.69 MiB | 1.05 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6a80f44+dirty | 1229.63 ms | 1221.77 ms | -7.86 ms |
| 865c0d9+dirty | 1229.65 ms | 1229.57 ms | -0.08 ms |
| 4ac2cff+dirty | 1217.83 ms | 1228.10 ms | 10.27 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 6a80f44+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 865c0d9+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| 4ac2cff+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
Previous results on branch: antonis/ref-RNSentryJsonUtils
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 11c0bc5+dirty | 1242.98 ms | 1250.56 ms | 7.58 ms |
| eff021d+dirty | 1228.45 ms | 1220.27 ms | -8.18 ms |
| f9a2e3c+dirty | 1222.06 ms | 1223.62 ms | 1.56 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 11c0bc5+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| eff021d+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
| f9a2e3c+dirty | 3.19 MiB | 4.25 MiB | 1.06 MiB |
antonis
requested review from
krystofwoldrich and
lucas-zimerman
as code owners
10 tasks
Comment on lines
+20
to
+24
| @Before | ||
| fun setUp() { | ||
| val context: Context = InstrumentationRegistry.getInstrumentation().targetContext | ||
| SoLoader.init(context, false) | ||
| } |
There was a problem hiding this comment.
This should not be needed. Let's remove it, to know 100% that these conversions can run before the RN initializes.
| JSONObject().apply { | ||
| put("stringKey", "stringValue") | ||
| put("booleanKey", true) | ||
| put("intKey", 123) |
There was a problem hiding this comment.
Let's also test test doubles/floats as those are common in Sentry configs.
| import org.json.JSONException; | ||
| import org.json.JSONObject; | ||
|
|
||
| public final class RNSentryJsonUtils { |
There was a problem hiding this comment.
Let's not expose this outside of the package.
10 tasks
|
Closing in favour of a simpler implementation in #4479 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
Depends on #4469
📜 Description
⛓️ PR Chain
💡 Motivation and Context
See #4451 (comment)
Part of #3608
💚 How did you test it?
CI, Manual
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
#skip-changelog