Skip to content

Silence TokenInterface::isAuthenticated deprecation in LoginListener #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

Jean85
Copy link
Contributor

@Jean85 Jean85 commented Aug 24, 2023

Before #720, we already silenced this deprecation in this same way: https://github.com/ste93cry/sentry-symfony/blob/251114f07d8a18c4cf07adad3b5a46a6c4f0c83e/src/EventListener/RequestListener.php#L135

This PR restores the silencing of the deprecation, since we check for the method existence immediately before.

@Jean85 Jean85 added the Bug label Aug 24, 2023
@Jean85 Jean85 requested a review from ste93cry August 24, 2023 16:02
@Jean85 Jean85 self-assigned this Aug 24, 2023
@Jean85 Jean85 linked an issue Aug 24, 2023 that may be closed by this pull request
@ste93cry ste93cry merged commit 542b6a2 into master Aug 25, 2023
@ste93cry ste93cry deleted the fix-login-listener-deprecation branch August 25, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LoginListener triggers deprecation
2 participants