Individual captures of DelayedMessageHandlingException #760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, thanks for opening this PR! Can you add a test to cover this use case? And a changelog entry? [EDIT] This seems not to be a new feature, it's present since Symfony 4.4: https://github.com/symfony/symfony/blob/d4a701096401ff6eaab32cbc5428767205b1c220/src/Symfony/Component/Messenger/Middleware/DispatchAfterCurrentBusMiddleware.php#L98-L100 |
|
@Jean85 Thanks, added those. Lmk what you think. |
Jean85
approved these changes
Sep 13, 2023
|
Released in 4.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thrown by https://github.com/symfony/symfony/blob/6.4/src/Symfony/Component/Messenger/Middleware/DispatchAfterCurrentBusMiddleware.php#L100 with any exceptions thrown after the current bus.