test(sourcemaps): Add cloudflare wrangler source maps e2e test #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
changed the base branch from
master
to
lms/feat-cf-wrangler-sourcemaps-wizard
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1000 +/- ##
=======================================
Coverage 27.98% 27.98%
=======================================
Files 130 130
Lines 14233 14233
Branches 882 882
=======================================
Hits 3983 3983
Misses 10233 10233
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lms24
force-pushed
the
lms/test-e2e-sourcemaps-wizard-cf-wrangler
branch
from
69ed443 to
555e6b6
Compare
Lms24
requested review from
AbhiPrasad,
a team and
RulaKhaled
and removed request for
a team
AbhiPrasad
approved these changes
May 23, 2025
e2e-tests/test-applications/cloudflare-wrangler-sourcemaps-test-app/yarn.lock
Outdated
Show resolved
Hide resolved
| import { Integration } from '../../lib/Constants'; | ||
| import * as path from 'path'; | ||
| import fs from 'fs'; | ||
| //@ts-expect-error - clifty is ESM only |
There was a problem hiding this comment.
Suggested change
| //@ts-expect-error - clifty is ESM only | |
| // @ts-expect-error - clifty is ESM only |
but also esm only 😢
There was a problem hiding this comment.
Maybe I should just emit CJS as well. Or actually, we probably need to adjust the build/TS config at some point in the wizard because I'm sure there are nicer ways to handle this than the ts-expect-error comment. Since we do this in a bunch of places (with clack), I'll follow up with another PR.
Lms24
force-pushed
the
lms/feat-cf-wrangler-sourcemaps-wizard
branch
from
0559287 to
b0ad164
Compare
chargome
approved these changes
Jun 2, 2025
Lms24
force-pushed
the
lms/test-e2e-sourcemaps-wizard-cf-wrangler
branch
2 times, most recently
from
b822349 to
6fce122
Compare
Lms24
force-pushed
the
lms/test-e2e-sourcemaps-wizard-cf-wrangler
branch
from
6fce122 to
b331287
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new e2e test app for the new cloudflare source maps wizard flow (#999). This introduces an (arguable 😅 ) improvement to our e2e test setup:
A couple of weeks ago I started working on a small NPM package called
cliftyto declaratively define a CLI interaction before executing the actual child process. The main goal of this package is to:IMHO this makes our e2e tests better readable compared to the solution we have in other tests and hopefully also less prone to flakes. Let's see if reviewers and CI agree :)
I propose we give the package a try in this e2e test and check for flakes or other weird behaviour. We can convert any of the other tests to this package whenever we want (or not).
#skip-changelog