feat(explore): Hide Confidence footer with 100% sample rate (#86206)

The extrapolation/confidence footer doesn't make sense if sample rate is
100%

Author: shruthilayaj

static/app/views/alerts/rules/metric/ruleForm.tsx

@@ -52,6 +52,7 @@ import ThresholdTypeForm from 'sentry/views/alerts/rules/metric/thresholdTypeFor
 import Triggers from 'sentry/views/alerts/rules/metric/triggers';
 import TriggersChart, {ErrorChart} from 'sentry/views/alerts/rules/metric/triggers/chart';
 import {
+  determineIsSampled,
   determineMultiSeriesConfidence,
   determineSeriesConfidence,
 } from 'sentry/views/alerts/rules/metric/utils/determineSeriesConfidence';
@@ -148,6 +149,7 @@ type State = {
   comparisonDelta?: number;
   confidence?: Confidence;
   isExtrapolatedChartData?: boolean;
+  isSampled?: boolean | null;
   seasonality?: AlertRuleSeasonality;
 } & DeprecatedAsyncComponent['state'];
 
@@ -989,7 +991,8 @@ class RuleFormContainer extends DeprecatedAsyncComponent<Props, State> {
     const confidence = isEventsStats(data)
       ? determineSeriesConfidence(data)
       : determineMultiSeriesConfidence(data);
-    this.setState({confidence});
+    const isSampled = determineIsSampled(data);
+    this.setState({confidence, isSampled});
   }
 
   handleHistoricalTimeSeriesDataFetched(
@@ -1124,6 +1127,7 @@ class RuleFormContainer extends DeprecatedAsyncComponent<Props, State> {
       chartError,
       chartErrorMessage,
       confidence,
+      isSampled,
     } = this.state;
 
     if (chartError) {
@@ -1171,6 +1175,7 @@ class RuleFormContainer extends DeprecatedAsyncComponent<Props, State> {
       onHistoricalDataLoaded: this.handleHistoricalTimeSeriesDataFetched,
       includeConfidence: alertType === 'eap_metrics',
       confidence,
+      isSampled,
     };
 
     let formattedQuery = `event.type:${eventTypes?.join(',')}`;

static/app/views/alerts/rules/metric/triggers/chart/index.tsx

@@ -58,6 +58,7 @@ import {getComparisonMarkLines} from 'sentry/views/alerts/utils/getComparisonMar
 import {AlertWizardAlertNames} from 'sentry/views/alerts/wizard/options';
 import {getAlertTypeFromAggregateDataset} from 'sentry/views/alerts/wizard/utils';
 import {ConfidenceFooter} from 'sentry/views/explore/charts/confidenceFooter';
+import {showConfidence} from 'sentry/views/explore/utils';
 
 import type {MetricRule, Trigger} from '../../types';
 import {
@@ -95,6 +96,7 @@ type Props = {
   includeConfidence?: boolean;
   includeHistorical?: boolean;
   isOnDemandMetricAlert?: boolean;
+  isSampled?: boolean | null;
   onConfidenceDataLoaded?: (data: EventsStats | MultiSeriesEventsStats | null) => void;
   onDataLoaded?: (data: EventsStats | MultiSeriesEventsStats | null) => void;
   onHistoricalDataLoaded?: (data: EventsStats | MultiSeriesEventsStats | null) => void;
@@ -490,7 +492,8 @@ class TriggersChart extends PureComponent<Props, State> {
         <ChartControls>
           {showTotalCount ? (
             <InlineContainer data-test-id="alert-total-events">
-              {dataset === Dataset.EVENTS_ANALYTICS_PLATFORM ? (
+              {dataset === Dataset.EVENTS_ANALYTICS_PLATFORM &&
+              showConfidence(this.props.isSampled) ? (
                 <ConfidenceFooter
                   sampleCount={extrapolationSampleCount ?? undefined}
                   confidence={confidence}

static/app/views/alerts/rules/metric/utils/determineSeriesConfidence.tsx

@@ -4,6 +4,10 @@ import type {
   MultiSeriesEventsStats,
 } from 'sentry/types/organization';
 import {defined} from 'sentry/utils';
+import {
+  isEventsStats,
+  isMultiSeriesEventsStats,
+} from 'sentry/views/dashboards/utils/isEventsStats';
 
 // Timeseries with more than this ratio of low confidence intervals will be considered low confidence
 const LOW_CONFIDENCE_THRESHOLD = 0.25;
@@ -116,3 +120,41 @@ export function combineConfidence(a: Confidence, b: Confidence): Confidence {
 
   return 'high';
 }
+
+export function determineIsSampled(
+  data: MultiSeriesEventsStats | EventsStats
+): boolean | null {
+  let hasSampledInterval = false;
+  let hasUnsampledInterval = false;
+
+  function resolve(sampleRate: number | null) {
+    if (!defined(sampleRate)) {
+      return;
+    }
+    if (sampleRate === 1) {
+      hasUnsampledInterval = true;
+    } else {
+      hasSampledInterval = true;
+    }
+  }
+
+  if (isEventsStats(data)) {
+    for (const sampleRate of data.meta?.accuracy?.samplingRate || []) {
+      if (defined(sampleRate)) {
+        resolve(sampleRate.value);
+      }
+    }
+  }
+
+  if (isMultiSeriesEventsStats(data)) {
+    for (const stats of Object.values(data)) {
+      for (const sampleRate of stats.meta?.accuracy?.samplingRate || []) {
+        if (defined(sampleRate)) {
+          resolve(sampleRate.value);
+        }
+      }
+    }
+  }
+
+  return hasSampledInterval ? true : hasUnsampledInterval ? false : null;
+}

static/app/views/alerts/rules/metric/utils/determineSeriesSampleCount.tsx

@@ -1,12 +1,12 @@
 import {defined} from 'sentry/utils';
 import type {TimeSeries} from 'sentry/views/dashboards/widgets/common/types';
 
-export function determineSeriesSampleCount(
+export function determineSeriesSampleCountAndIsSampled(
   data: TimeSeries[],
   topNMode: boolean
-): number {
+): {isSampled: boolean | null; sampleCount: number} {
   if (data.length <= 0) {
-    return 0;
+    return {sampleCount: 0, isSampled: null};
   }
 
   if (topNMode) {
@@ -25,15 +25,28 @@ export function determineSeriesSampleCount(
       // to justify the potential low accuracy warning.
       Math.max;
 
+  let hasSampledInterval = false;
+  let hasUnsampledInterval = false;
+
   const series: number[] = data[0]?.sampleCount?.map(item => item.value) ?? [];
 
-  for (let i = 1; i < data.length; i++) {
+  for (let i = 0; i < data.length; i++) {
     if (defined(data[i]?.sampleCount)) {
       for (let j = 0; j < data[i]!.sampleCount!.length; j++) {
-        series[j] = merge(series[j]!, data[i]!.sampleCount![j]!.value);
+        if (i > 0) {
+          series[j] = merge(series[j]!, data[i]!.sampleCount![j]!.value);
+        }
+        const sampleRate = data[i]?.samplingRate?.[j]?.value;
+        if (sampleRate === 1) {
+          hasUnsampledInterval = true;
+        } else if (defined(sampleRate) && sampleRate < 1) {
+          hasSampledInterval = true;
+        }
       }
     }
   }
 
-  return series.reduce((sum, count) => sum + count, 0);
+  const isSampled = hasSampledInterval ? true : hasUnsampledInterval ? false : null;
+
+  return {sampleCount: series.reduce((sum, count) => sum + count, 0), isSampled};
 }

static/app/views/dashboards/widgetCard/spansWidgetQueries.tsx

@@ -14,7 +14,7 @@ import {dedupeArray} from 'sentry/utils/dedupeArray';
 import type {EventsTableData, TableData} from 'sentry/utils/discover/discoverQuery';
 import getDynamicText from 'sentry/utils/getDynamicText';
 import {determineSeriesConfidence} from 'sentry/views/alerts/rules/metric/utils/determineSeriesConfidence';
-import {determineSeriesSampleCount} from 'sentry/views/alerts/rules/metric/utils/determineSeriesSampleCount';
+import {determineSeriesSampleCountAndIsSampled} from 'sentry/views/alerts/rules/metric/utils/determineSeriesSampleCount';
 import {SpansConfig} from 'sentry/views/dashboards/datasetConfig/spans';
 import {getTopEvents} from 'sentry/views/dashboards/widgetBuilder/utils/getTopEvents';
 import {combineConfidenceForSeries} from 'sentry/views/explore/utils';
@@ -70,7 +70,7 @@ function SpansWidgetQueries({
 
     if (isEventsStats(result)) {
       seriesConfidence = determineSeriesConfidence(result);
-      seriesSampleCount = determineSeriesSampleCount(
+      const {sampleCount: calculatedSampleCount} = determineSeriesSampleCountAndIsSampled(
         [
           convertEventsStatsToTimeSeriesData(
             widget.queries[0]?.aggregates[0] ?? '',
@@ -79,11 +79,16 @@ function SpansWidgetQueries({
         ],
         !!topEvents
       );
+      seriesSampleCount = calculatedSampleCount;
     } else {
       const dedupedYAxes = dedupeArray(widget.queries[0]?.aggregates ?? []);
       const seriesMap = transformToSeriesMap(result, dedupedYAxes);
       const series = dedupedYAxes.flatMap(yAxis => seriesMap[yAxis]).filter(defined);
-      seriesSampleCount = determineSeriesSampleCount(series, !!topEvents);
+      const {sampleCount: calculatedSampleCount} = determineSeriesSampleCountAndIsSampled(
+        series,
+        !!topEvents
+      );
+      seriesSampleCount = calculatedSampleCount;
       seriesConfidence = combineConfidenceForSeries(series);
     }
 

static/app/views/explore/charts/index.tsx

@@ -15,7 +15,7 @@ import {DiscoverDatasets} from 'sentry/utils/discover/types';
 import {MutableSearch} from 'sentry/utils/tokenizeSearch';
 import usePageFilters from 'sentry/utils/usePageFilters';
 import usePrevious from 'sentry/utils/usePrevious';
-import {determineSeriesSampleCount} from 'sentry/views/alerts/rules/metric/utils/determineSeriesSampleCount';
+import {determineSeriesSampleCountAndIsSampled} from 'sentry/views/alerts/rules/metric/utils/determineSeriesSampleCount';
 import {WidgetSyncContextProvider} from 'sentry/views/dashboards/contexts/widgetSyncContext';
 import {TimeSeriesWidgetVisualization} from 'sentry/views/dashboards/widgets/timeSeriesWidget/timeSeriesWidgetVisualization';
 import {Widget} from 'sentry/views/dashboards/widgets/widget/widget';
@@ -28,6 +28,7 @@ import {
 } from 'sentry/views/explore/contexts/pageParamsContext';
 import {useChartInterval} from 'sentry/views/explore/hooks/useChartInterval';
 import {useTopEvents} from 'sentry/views/explore/hooks/useTopEvents';
+import {showConfidence} from 'sentry/views/explore/utils';
 import {
   ChartType,
   useSynchronizeCharts,
@@ -135,7 +136,10 @@ export function ExploreCharts({
 
       const {data, error, loading} = getSeries(dedupedYAxes, formattedYAxes);
 
-      const sampleCount = determineSeriesSampleCount(data, isTopN);
+      const {sampleCount, isSampled} = determineSeriesSampleCountAndIsSampled(
+        data,
+        isTopN
+      );
 
       return {
         chartIcon: <IconGraph type={chartIcon} />,
@@ -148,6 +152,7 @@ export function ExploreCharts({
         loading,
         confidence: confidences[index],
         sampleCount,
+        isSampled,
       };
     });
   }, [confidences, getSeries, visualizes, isTopN]);
@@ -284,7 +289,8 @@ export function ExploreCharts({
                 />
               }
               Footer={
-                dataset === DiscoverDatasets.SPANS_EAP_RPC && (
+                dataset === DiscoverDatasets.SPANS_EAP_RPC &&
+                showConfidence(chartInfo.isSampled) && (
                   <ConfidenceFooter
                     sampleCount={chartInfo.sampleCount}
                     confidence={chartInfo.confidence}

static/app/views/explore/multiQueryMode/queryVisualizations/chart.tsx

@@ -17,7 +17,7 @@ import usePageFilters from 'sentry/utils/usePageFilters';
 import usePrevious from 'sentry/utils/usePrevious';
 import useProjects from 'sentry/utils/useProjects';
 import {Dataset} from 'sentry/views/alerts/rules/metric/types';
-import {determineSeriesSampleCount} from 'sentry/views/alerts/rules/metric/utils/determineSeriesSampleCount';
+import {determineSeriesSampleCountAndIsSampled} from 'sentry/views/alerts/rules/metric/utils/determineSeriesSampleCount';
 import {TimeSeriesWidgetVisualization} from 'sentry/views/dashboards/widgets/timeSeriesWidget/timeSeriesWidgetVisualization';
 import {Widget} from 'sentry/views/dashboards/widgets/widget/widget';
 import {EXPLORE_CHART_TYPE_OPTIONS} from 'sentry/views/explore/charts';
@@ -31,7 +31,7 @@ import {
   useUpdateQueryAtIndex,
 } from 'sentry/views/explore/multiQueryMode/locationUtils';
 import {INGESTION_DELAY} from 'sentry/views/explore/settings';
-import {combineConfidenceForSeries} from 'sentry/views/explore/utils';
+import {combineConfidenceForSeries, showConfidence} from 'sentry/views/explore/utils';
 import {ChartType} from 'sentry/views/insights/common/components/chart';
 import type {useSortedTimeSeries} from 'sentry/views/insights/common/queries/useSortedTimeSeries';
 import {getAlertsUrl} from 'sentry/views/insights/common/utils/getAlertsUrl';
@@ -123,7 +123,7 @@ export function MultiQueryModeChart({
   ]);
 
   const {data, error, loading} = getSeries();
-  const sampleCount = determineSeriesSampleCount(data, isTopN);
+  const {sampleCount, isSampled} = determineSeriesSampleCountAndIsSampled(data, isTopN);
 
   const visualizationType =
     queryParts.chartType === ChartType.LINE
@@ -301,11 +301,13 @@ export function MultiQueryModeChart({
         />
       }
       Footer={
-        <ConfidenceFooter
-          sampleCount={sampleCount}
-          confidence={confidence}
-          topEvents={isTopN ? numSeries : undefined}
-        />
+        showConfidence(isSampled) && (
+          <ConfidenceFooter
+            sampleCount={sampleCount}
+            confidence={confidence}
+            topEvents={isTopN ? numSeries : undefined}
+          />
+        )
       }
     />
   );

static/app/views/explore/utils.tsx

@@ -167,3 +167,10 @@ export function limitMaxPickableDays(organization: Organization): {
     },
   };
 }
+
+export function showConfidence(isSampled: boolean | null | undefined) {
+  if (defined(isSampled) && isSampled === false) {
+    return false;
+  }
+  return true;
+}