Skip to content

feat(explore): Hide Confidence footer with 100% sample rate #86206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2025
Merged

feat(explore): Hide Confidence footer with 100% sample rate #86206

merged 3 commits into from
Mar 3, 2025

Conversation

shruthilayaj
Copy link
Member

The extrapolation/confidence footer doesn't make sense if sample rate is 100%

@shruthilayaj shruthilayaj requested review from a team as code owners March 3, 2025 17:56
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Mar 3, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 3, 2025 •
edited
Loading

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
9627 2 9625 4
View the top 2 failed test(s) by shortest run time 
spansWidgetQueries calculates the confidence for a multi series
Stack Traces | 1.02s run time 
Error: Unable to find an element with the text: high. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../dashboards/widgetCard/spansWidgetQueries.spec.tsx:95:46)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)
spansWidgetQueries calculates the confidence for a single series
Stack Traces | 1.04s run time 
Error: Unable to find an element with the text: low. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.

Ignored nodes: comments, script, style
...
    at waitForWrapper (.../sentry/sentry/node_modules/@.../dom/dist/wait-for.js:163:27)
    at .../sentry/sentry/node_modules/@.../dom/dist/query-helpers.js:86:33
    at Object.<anonymous> (.../dashboards/widgetCard/spansWidgetQueries.spec.tsx:45:46)
    at Promise.then.completed (.../sentry/sentry/node_modules/jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../sentry/sentry/node_modules/jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:105:5)
    at _runTest (.../sentry/sentry/node_modules/jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:126:9)
    at _runTestsForDescribeBlock (.../sentry/sentry/node_modules/jest-circus/build/run.js:121:9)
    at run (.../sentry/sentry/node_modules/jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../sentry/sentry/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:367:16)
    at runTest (.../sentry/sentry/node_modules/jest-runner/build/runTest.js:444:34)
    at Object.worker (.../sentry/sentry/node_modules/jest-runner/build/testWorker.js:106:12)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

edwardgou-sentry
edwardgou-sentry approved these changes Mar 3, 2025
View reviewed changes
Copy link
Contributor

@edwardgou-sentry edwardgou-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but looks like ci is complaining about some references because determineSeriesSampleCount changed to determineSeriesSampleCountAndIsSampled

@shruthilayaj shruthilayaj requested a review from a team as a code owner March 3, 2025 19:53
@shruthilayaj shruthilayaj merged commit 735880e into master Mar 3, 2025
42 checks passed
@shruthilayaj shruthilayaj deleted the shruthi/feat/hide-confidence-footer-with-100-sample-rate branch March 3, 2025 20:07
jan-auer added a commit that referenced this pull request Mar 4, 2025
@jan-auer
Merge branch 'master' into feat/change-span-topics
45c0dc2 
* master: (50 commits)
  fix(laravel-insights): fix seconds vs milliseconds in jobs widget (#86273)
  feat(assemble): Implement new query for finding missing chunk (#85614)
  fix(issue-views): Fix buggy dragging  (#86264)
  feat(workflow_engine): Add DELETE Workflow Endpoint (#86246)
  feat(crons): Improve wording for project field in validator (#86158)
  ref(ui): Remove unused images (#86249)
  feat(compare queries): tightened padding, added tooltips, and fixed panel heights (#86227)
  fix(billing): update billing details tab (#86152)
  fix(nav): Show same nav items when user is in org or user settings. (#86161)
  feat(ourlogs): Add alpha js sdk for adding logging (#86239)
  chore(dashboards): Remove chart from Releases drawer (#86237)
  ref(flags): fix audit log table badge style (#86224)
  fix(replay): Remove extra border & padding from replay snippets (#86223)
  ref(insights): remove performance-landing-page-stats-period flag (#86200)
  fix(insights): Filter span samples by environment (#86198)
  ref(insights): Replace usage of `<ReleaseSeries>` in `<InsightsTimeSeriesWidget>` (#86129)
  feat(explore): Hide Confidence footer with 100% sample rate (#86206)
  ref(dashboards): Move unit scaling into `Plottable` (#86116)
  tests(derived_code_mappings): Do not create object in parametrization section (#86188)
  chore: update gsApp CODEOWNERS  (#86222)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edwardgou-sentry edwardgou-sentry edwardgou-sentry approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shruthilayaj @edwardgou-sentry