Skip to content

Commit 8196928

Browse files
authored
fix(starfish): Fix ordering of span group breakdown (#51691)
Span duration wasn't a selected field for that `EventView`, so the data was coming back unsorted, and the breakdown looked weird. Database was completely missing! The selected fields were updated in #51051 but the sort was left incorrect.
1 parent 4c15a4f commit 8196928

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

static/app/views/starfish/views/webServiceView/spanGroupBreakdownContainer.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ const getEventView = (
197197
start: pageFilters.datetime.start ?? undefined,
198198
end: pageFilters.datetime.end ?? undefined,
199199
range: pageFilters.datetime.period ?? undefined,
200-
orderby: '-sum_span_duration',
200+
orderby: '-sum_span_self_time',
201201
projects: [1],
202202
version: 2,
203203
topEvents: groups.length > 0 ? '4' : undefined,
@@ -218,7 +218,7 @@ const getCumulativeTimeEventView = (
218218
start: pageFilters.datetime.start ?? undefined,
219219
end: pageFilters.datetime.end ?? undefined,
220220
range: pageFilters.datetime.period ?? undefined,
221-
orderby: '-sum_span_duration',
221+
orderby: '-sum_span_self_time',
222222
projects: [1],
223223
version: 2,
224224
topEvents: groups.length > 0 ? '4' : undefined,

0 commit comments

Comments
 (0)