fix(starfish): Fix ordering of span group breakdown #51691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Span duration wasn't a selected field for that `EventView`, so the data was coming back unsorted, and the breakdown looked weird.
github-actions
bot
added
the
Scope: Frontend
shruthilayaj
approved these changes
Jun 27, 2023
0Calories
approved these changes
Jun 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Span duration wasn't a selected field for that
EventView, so the data was coming back unsorted, and the breakdown looked weird. Database was completely missing! The selected fields were updated in #51051 but the sort was left incorrect.Before:
After:
