Skip to content

Commit b7deff8

Browse files
authored
fix(explore): Sample table column rendering is wrong (#81238)
The event view contained a different ordering of columns from what was expected.
1 parent 614b5d8 commit b7deff8

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

static/app/views/explore/tables/spansTable.tsx

+7-7
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,14 @@ export function SpansTable({setError}: SpansTableProps) {
5050
const [visualizes] = useVisualizes();
5151
const organization = useOrganization();
5252

53+
const visibleFields = useMemo(
54+
() => (fields.includes('id') ? fields : ['id', ...fields]),
55+
[fields]
56+
);
57+
5358
const eventView = useMemo(() => {
5459
const queryFields = [
55-
...fields,
60+
...visibleFields,
5661
'project',
5762
'trace',
5863
'transaction.span_id',
@@ -78,7 +83,7 @@ export function SpansTable({setError}: SpansTableProps) {
7883
};
7984

8085
return EventView.fromNewQueryWithPageFilters(discoverQuery, selection);
81-
}, [dataset, fields, sorts, query, selection]);
86+
}, [dataset, sorts, query, selection, visibleFields]);
8287

8388
const columns = useMemo(() => eventView.getColumns(), [eventView]);
8489

@@ -103,11 +108,6 @@ export function SpansTable({setError}: SpansTableProps) {
103108
userQuery: query,
104109
});
105110

106-
const visibleFields = useMemo(
107-
() => (fields.includes('id') ? fields : ['id', ...fields]),
108-
[fields]
109-
);
110-
111111
const {tableStyles} = useTableStyles({
112112
items: visibleFields.map(field => {
113113
return {

0 commit comments

Comments
 (0)