Skip to content

fix(explore): Sample table column rendering is wrong #81238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

Zylphrex
Copy link
Member

The event view contained a different ordering of columns from what was expected.

@Zylphrex Zylphrex requested a review from a team as a code owner November 25, 2024 16:25
@Zylphrex Zylphrex enabled auto-merge (squash) November 25, 2024 16:25
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Nov 25, 2024
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
static/app/views/explore/tables/spansTable.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #81238   +/-   ##
=======================================
  Coverage   80.34%   80.34%           
=======================================
  Files        7219     7219           
  Lines      319544   319544           
  Branches    20779    20779           
=======================================
  Hits       256736   256736           
+ Misses      62417    62414    -3     
- Partials      391      394    +3     

@Zylphrex Zylphrex merged commit b7deff8 into master Nov 25, 2024
44 of 45 checks passed
@Zylphrex Zylphrex deleted the txiao/fix/sample-table-ordering branch November 25, 2024 17:03
evanh pushed a commit that referenced this pull request Nov 25, 2024
The event view contained a different ordering of columns from what was
expected.
andrewshie-sentry pushed a commit that referenced this pull request Dec 2, 2024
The event view contained a different ordering of columns from what was
expected.
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants