Skip to content

Commit c2959db

Browse files
authored
chore(github-growth): more FE analytics (#56507)
1 parent d2b3880 commit c2959db

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

static/app/components/modals/inviteMissingMembersModal/index.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,7 @@ export function InviteMissingMembersModal({
292292
analyticsEventKey="github_invite_modal.invite"
293293
analyticsParams={{
294294
invited_all: memberInvites.length === selectedCount,
295+
invited_count: selectedCount,
295296
}}
296297
>
297298
{inviteButtonLabel()}

static/app/utils/analytics/growthAnalyticsEvents.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ export type GrowthEventParameters = {
6363
guide: string;
6464
};
6565
'github_invite_banner.snoozed': {};
66-
'github_invite_banner.viewed': {};
66+
'github_invite_banner.viewed': {members_shown: number};
6767
'growth.clicked_enter_sandbox': {
6868
scenario: string;
6969
source?: string;

static/app/views/settings/organizationMembers/inviteBanner.tsx

+4-1
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@ import useApi from 'sentry/utils/useApi';
2222
import {useLocation} from 'sentry/utils/useLocation';
2323
import withOrganization from 'sentry/utils/withOrganization';
2424

25+
const MAX_MEMBERS_TO_SHOW = 5;
26+
2527
type Props = {
2628
allowedRoles: OrgRole[];
2729
missingMembers: {integration: string; users: MissingMember[]};
@@ -96,6 +98,7 @@ export function InviteBanner({
9698
if (isEligibleForBanner && showBanner) {
9799
trackAnalytics('github_invite_banner.viewed', {
98100
organization,
101+
members_shown: missingMembers.users.slice(0, MAX_MEMBERS_TO_SHOW).length,
99102
});
100103
}
101104
if (!isEligibleForBanner || !showBanner) {
@@ -127,7 +130,7 @@ export function InviteBanner({
127130

128131
const users = missingMembers.users;
129132

130-
const cards = users.slice(0, 5).map(member => {
133+
const cards = users.slice(0, MAX_MEMBERS_TO_SHOW).map(member => {
131134
const username = member.externalId.split(':').pop();
132135
return (
133136
<MemberCard

0 commit comments

Comments
 (0)