chore(github-invite): more FE analytics #56507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
cathteng
commented
Sep 19, 2023
cathteng
commented
- Track the number of members being shown in the banner
- Track the number of people being invited through the modal
github-actions
bot
added
the
Scope: Frontend
schew2381
reviewed
Sep 19, 2023
| @@ -96,6 +96,7 @@ export function InviteBanner({ | |||
| if (isEligibleForBanner && showBanner) { | |||
| trackAnalytics('github_invite_banner.viewed', { | |||
| organization, | |||
| members_shown: missingMembers.users.slice(0, 5).length, | |||
There was a problem hiding this comment.
Why is this indexed from 0 to 5?
There was a problem hiding this comment.
we only show up to 5 members on the banner
There was a problem hiding this comment.
Is there some constant we use to determine the number of people shown we can use instead of hardcoding the 5
There was a problem hiding this comment.
probably. i use slice elsewhere in this file too
nhsiehgit
approved these changes
Sep 20, 2023
dashed
approved these changes
Sep 20, 2023
cathteng
deleted the
cathy/github-growth/track-members-shown-in-banner
branch
cathteng
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.