ref(replay): improve error messages for invalid searches that raise CouldNotParseValue (#82048)

Closes #80574

CouldNotParseValue is a custom error we raise in
[parsers.py](https://github.com/getsentry/sentry/blob/9241bebfa46dc4d8676cc80219c3786b7006acba/src/sentry/replays/lib/new_query/parsers.py).
They contain messages useful for users, but we need to include it in
this exc handler first.

Also adds the parsed value to the msg

Relates to 
- #78636

Author: aliu39

src/sentry/replays/endpoints/project_replay_clicks_index.py

@@ -213,7 +213,9 @@ def handle_search_filters(
             except OperatorNotSupported:
                 raise ParseError(f"Invalid operator specified for `{search_filter.key.name}`")
             except CouldNotParseValue:
-                raise ParseError(f"Could not parse value for `{search_filter.key.name}`")
+                raise ParseError(
+                    f"Could not parse value '{search_filter.value.value}' for `{search_filter.key.name}`"
+                )
 
             if look_back == "AND":
                 look_back = None

src/sentry/replays/lib/new_query/parsers.py

@@ -30,7 +30,6 @@ def parse_duration(value: str) -> int:
     milliseconds = parse_int(value)
     if milliseconds % 1000:
         # TODO: remove once we support milliseconds.
-        # TODO: this error isn't actually returned to the frontend, it's caught and then we raise a ParseError
         raise CouldNotParseValue(
             f"Replays only supports second-resolution timestamps at this time. Try '{milliseconds // 1000}s' instead."
         )

src/sentry/replays/usecases/query/__init__.py

@@ -71,7 +71,9 @@ def handle_viewed_by_me_filters(
 
         value = search_filter.value.value
         if not isinstance(value, str) or value.lower() not in ["true", "false"]:
-            raise ParseError(f"Could not parse value for `{search_filter.key.name}`")
+            raise ParseError(
+                f"Could not parse value '{search_filter.value.value}' for `{search_filter.key.name}`"
+            )
         value = value.lower() == "true"
 
         if request_user_id is None:
@@ -103,14 +105,20 @@ def handle_search_filters(
         # are top level filters they are implicitly AND'ed in the WHERE/HAVING clause.  Otherwise
         # explicit operators are used.
         if isinstance(search_filter, SearchFilter):
+
             try:
                 condition = search_filter_to_condition(search_config, search_filter)
                 if condition is None:
                     raise ParseError(f"Unsupported search field: {search_filter.key.name}")
             except OperatorNotSupported:
                 raise ParseError(f"Invalid operator specified for `{search_filter.key.name}`")
-            except CouldNotParseValue:
-                raise ParseError(f"Could not parse value for `{search_filter.key.name}`")
+            except CouldNotParseValue as e:
+                err_msg = f"Could not parse value '{search_filter.value.value}' for `{search_filter.key.name}`."
+                if e.args:
+                    err_msg += (
+                        f" {e.args[0]}"  # avoid using str(e) as it may expose stack trace info
+                    )
+                raise ParseError(err_msg)
 
             if look_back == "AND":
                 look_back = None

tests/sentry/replays/test_organization_replay_index.py

@@ -584,7 +584,9 @@ def test_get_replays_user_filters(self):
             self.mock_event_links(seq1_timestamp, project.id, "debug", replay1_id, uuid.uuid4().hex)
         )
         self.store_replays(
-            mock_replay_viewed(seq1_timestamp.timestamp(), project.id, replay1_id, viewed_by_id=1)
+            mock_replay_viewed(
+                seq1_timestamp.timestamp(), project.id, replay1_id, viewed_by_id=self.user.id
+            )
         )
 
         with self.feature(self.features):
@@ -610,8 +612,6 @@ def test_get_replays_user_filters(self):
                 "duration:<18s",
                 "duration:>=17s",
                 "duration:<=17s",
-                # "duration:[16s,17s]",  # TODO: need to add duration_in_filters in event_search.py
-                # "!duration:[16s,18s]",
                 "duration:17000ms",  # If duration value is not equal to a whole number of seconds, the endpoint fails.
                 "duration:<1m",
                 "duration:<1min",
@@ -682,12 +682,14 @@ def test_get_replays_user_filters(self):
                 "count_infos:2",
                 "count_infos:>1",
                 "count_infos:<3",
-                "viewed_by_id:1",
-                "!viewed_by_id:2",
-                "viewed_by_id:[1,2]",
-                "seen_by_id:1",
-                "!seen_by_id:2",
-                "seen_by_id:[1,2]",
+                f"viewed_by_id:{self.user.id}",
+                f"!viewed_by_id:{self.user.id+1}",
+                f"viewed_by_id:[{self.user.id+3},{self.user.id}]",
+                f"seen_by_id:{self.user.id}",
+                f"!seen_by_id:{self.user.id + 1}",
+                f"seen_by_id:[{self.user.id + 3},{self.user.id}]",
+                "viewed_by_me:true",
+                "seen_by_me:true",
             ]
 
             for query in queries:
@@ -736,8 +738,10 @@ def test_get_replays_user_filters(self):
                 "!c:*st",
                 "!activity:8",
                 "activity:<2",
-                "viewed_by_id:2",
-                "seen_by_id:2",
+                f"viewed_by_id:{self.user.id+1}",
+                f"seen_by_id:{self.user.id+1}",
+                "viewed_by_me:false",
+                "seen_by_me:false",
                 "user.email:[[email protected]]",
                 "!user.email:[[email protected], [email protected]]",
             ]
@@ -938,7 +942,7 @@ def test_get_replays_filter_bad_operator(self):
         with self.feature(self.features):
             for query in queries:
                 response = self.client.get(self.url + f"?field=id&query={query}")
-                assert response.status_code == 400
+                assert response.status_code == 400, query
 
     def test_get_replays_filter_bad_value(self):
         """Test replays conform to the interchange format."""
@@ -956,20 +960,28 @@ def test_get_replays_filter_bad_value(self):
         with self.feature(self.features):
             for query in queries:
                 response = self.client.get(self.url + f"?query={query}")
-                assert response.status_code == 400
-                field = query.split(":")[0]
-                assert field.encode() in response.content
+                assert response.status_code == 400, query
 
-    # No such thing as a bad field with the tag filtering behavior.
-    #
-    # def test_get_replays_filter_bad_field(self):
-    #     """Test replays conform to the interchange format."""
-    #     self.create_project(teams=[self.team])
+    def test_get_replays_filter_bad_duration_error_messages(self):
+        # TODO: remove once we support ms timestamps
+        self.create_project(teams=[self.team])
+        queries = [
+            "duration:1004ms",
+            "duration:7.3s",
+            "duration:1.33min",
+        ]
 
-    #     with self.feature(self.features):
-    #         response = self.client.get(self.url + "?query=xyz:a")
-    #         assert response.status_code == 400
-    #         assert b"xyz" in response.content
+        with self.feature(self.features):
+            for query in queries:
+                response = self.client.get(self.url + f"?query={query}")
+                assert response.status_code == 400, query
+                assert (
+                    b"Replays only supports second-resolution timestamps at this time"
+                    in response.content
+                ), query
+                assert b"duration" in response.content, query
+
+    # Note: there's no such thing as a bad field with the tag filtering behavior.
 
     def test_get_replays_unknown_field(self):
         """Test replays unknown fields raise a 400 error."""