Skip to content

[Replay Search] Use backend exceptions to enhance index page error messages #80574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
aliu39 opened this issue Nov 12, 2024 · 1 comment · Fixed by #82048
Closed

[Replay Search] Use backend exceptions to enhance index page error messages #80574

aliu39 opened this issue Nov 12, 2024 · 1 comment · Fixed by #82048
Assignees
@aliu39
Labels
Product Area: Replays

Comments

@aliu39
Copy link
Member

aliu39 commented Nov 12, 2024

On the backend we raise CouldNotParseValue exceptions which are caught and re-raised as ParseErrors. Only ParseError messages are returned to the user, but it seems like the CouldNotParseValue messages are useful too, since they give field-specific info.
@getsantry
Copy link
Contributor

getsantry bot commented Nov 12, 2024

Routing to @getsentry/product-owners-replays for triage ⏲️

@aliu39 aliu39 self-assigned this Nov 12, 2024
@aliu39 aliu39 mentioned this issue Dec 12, 2024
Merged
@aliu39 aliu39 closed this as completed in 56caa2f Dec 13, 2024
evanh pushed a commit that referenced this issue Dec 17, 2024
@aliu39 @evanh
ref(replay): improve error messages for invalid searches that raise C…
d11793b 
…ouldNotParseValue (#82048)

Closes #80574

CouldNotParseValue is a custom error we raise in
[parsers.py](https://github.com/getsentry/sentry/blob/9241bebfa46dc4d8676cc80219c3786b7006acba/src/sentry/replays/lib/new_query/parsers.py).
They contain messages useful for users, but we need to include it in
this exc handler first.

Also adds the parsed value to the msg

Relates to 
- #78636
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2024
andrewshie-sentry pushed a commit that referenced this issue Jan 2, 2025
@aliu39 @andrewshie-sentry
ref(replay): improve error messages for invalid searches that raise C…
af3219e 
…ouldNotParseValue (#82048)

Closes #80574

CouldNotParseValue is a custom error we raise in
[parsers.py](https://github.com/getsentry/sentry/blob/9241bebfa46dc4d8676cc80219c3786b7006acba/src/sentry/replays/lib/new_query/parsers.py).
They contain messages useful for users, but we need to include it in
this exc handler first.

Also adds the parsed value to the msg

Relates to 
- #78636
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aliu39 aliu39

Labels
Product Area: Replays
Projects
GitHub Issues with 👀 3
Archived in project
Milestone
No milestone
1 participant
@aliu39