Skip to content

Commit f31695e

Browse files
authored
fix(iphone-codes): update BE mapping; remove unused method (#82094)
1 parent 4a189c1 commit f31695e

File tree

1 file changed

+70
-32
lines changed

1 file changed

+70
-32
lines changed

src/sentry/profiles/device.py

+70-32
Original file line numberDiff line numberDiff line change
@@ -103,19 +103,23 @@ def get_platform(device_os_name: str, is_emulator: bool) -> Platform:
103103
IPADAIRGEN3 = "iPad Air (3rd gen)"
104104
IPADAIRGEN4 = "iPad Air (4th gen)"
105105
IPADAIRGEN5 = "iPad Air (5th gen)"
106+
IPADAIRGEN6 = "iPad Air (6th gen)"
107+
IPADAIRGEN7 = "iPad Air (7th gen)"
106108

107-
IPADPRO12GEN1 = "iPad Pro (12.9-inch, 1st gen)"
108-
IPADPRO9GEN1 = "iPad Pro (9.7-inch, 1st gen)"
109-
IPADPRO12GEN2 = "iPad Pro (12.9-inch, 2nd gen)"
109+
IPADPRO9GEN1 = "iPad Pro (9.7-inch)"
110110
IPADPRO10 = "iPad Pro (10.5-inch)"
111111
IPADPRO11GEN1 = "iPad Pro (11-inch, 1st gen)"
112-
IPADPRO12GEN3 = "iPad Pro (12.9-inch, 3rd gen)"
113112
IPADPRO11GEN2 = "iPad Pro (11-inch, 2nd gen)"
114-
IPADPRO12GEN4 = "iPad Pro (12.9-inch, 4th gen)"
115113
IPADPRO11GEN3 = "iPad Pro (11-inch, 3rd gen)"
116114
IPADPRO11GEN4 = "iPad Pro (11-inch, 4th gen)"
115+
IPADPRO11GEN5 = "iPad Pro (11 inch, 5th gen)"
116+
IPADPRO12GEN1 = "iPad Pro (12.9-inch, 1st gen)"
117+
IPADPRO12GEN2 = "iPad Pro (12.9-inch, 2nd gen)"
118+
IPADPRO12GEN3 = "iPad Pro (12.9-inch, 3rd gen)"
119+
IPADPRO12GEN4 = "iPad Pro (12.9-inch, 4th gen)"
117120
IPADPRO12GEN5 = "iPad Pro (12.9-inch, 5th gen)"
118-
IPADPRO12GEN6 = "iPad Pro (12.9-inch 6th gen)"
121+
IPADPRO12GEN6 = "iPad Pro (12.9-inch, 6th gen)"
122+
IPADPRO12GEN7 = "iPad Pro (12.9-inch, 7th gen)"
119123

120124
IPADMINIGEN1 = "iPad mini (1st gen)"
121125
IPADMINI2 = "iPad mini 2"
@@ -130,15 +134,21 @@ def get_platform(device_os_name: str, is_emulator: bool) -> Platform:
130134
APPLEWATCHSERIES3 = "Apple Watch Series 3"
131135
APPLEWATCHSERIES4 = "Apple Watch Series 4"
132136
APPLEWATCHSERIES5 = "Apple Watch Series 5"
133-
APPLEWATCHSE = "Apple Watch SE"
134137
APPLEWATCHSERIES6 = "Apple Watch Series 6"
138+
APPLEWATCHSERIES7 = "Apple Watch Series 7"
139+
APPLEWATCHSERIES8 = "Apple Watch Series 8"
140+
APPLEWATCHSERIES9 = "Apple Watch Series 9"
141+
APPLEWATCHSERIES10 = "Apple Watch Series 10"
142+
APPLEWATCHSE1 = "Apple Watch SE (1st gen)"
143+
APPLEWATCHSE2 = "Apple Watch SE (2nd gen)"
135144

136145
APPLETVGEN1 = "Apple TV (1st gen)"
137146
APPLETVGEN2 = "Apple TV (2nd gen)"
138147
APPLETVGEN3 = "Apple TV (3rd gen)"
139148

140-
# https:#www.theiphonewiki.com/wiki/Models
149+
# see https://theapplewiki.com/wiki/models
141150
IOS_MODELS: dict[str, str] = {
151+
# iPhone
142152
"iPhone1,1": "iPhone (1st gen)",
143153
"iPhone1,2": "iPhone 3G",
144154
"iPhone2,1": "iPhone 3GS",
@@ -192,13 +202,19 @@ def get_platform(device_os_name: str, is_emulator: bool) -> Platform:
192202
"iPhone15,5": "iPhone 15 Plus",
193203
"iPhone16,1": "iPhone 15 Pro",
194204
"iPhone16,2": "iPhone 15 Pro Max",
205+
"iPhone17,1": "iPhone 16 Pro",
206+
"iPhone17,2": "iPhone 16 Pro Max",
207+
"iPhone17,3": "iPhone 16",
208+
"iPhone17,4": "iPhone 16 Plus",
209+
# iPod Touch
195210
"iPod1,1": "iPod touch (1st gen)",
196211
"iPod2,1": "iPod touch (2nd gen)",
197212
"iPod3,1": "iPod touch (3rd gen)",
198213
"iPod4,1": "iPod touch (4th gen)",
199214
"iPod5,1": "iPod touch (5th gen)",
200215
"iPod7,1": "iPod touch (6th gen)",
201216
"iPod9,1": "iPod touch (7th gen)",
217+
# iPad
202218
"iPad1,1": "iPad (1st gen)",
203219
"iPad2,1": IPAD2,
204220
"iPad2,2": IPAD2,
@@ -220,6 +236,7 @@ def get_platform(device_os_name: str, is_emulator: bool) -> Platform:
220236
"iPad11,7": IPADGEN8,
221237
"iPad12,1": IPADGEN9,
222238
"iPad12,2": IPADGEN9,
239+
# iPad Air
223240
"iPad4,1": IPADAIRGEN1,
224241
"iPad4,2": IPADAIRGEN1,
225242
"iPad4,3": IPADAIRGEN1,
@@ -231,10 +248,15 @@ def get_platform(device_os_name: str, is_emulator: bool) -> Platform:
231248
"iPad13,2": IPADAIRGEN4,
232249
"iPad13,16": IPADAIRGEN5,
233250
"iPad13,17": IPADAIRGEN5,
251+
"iPad14,8": IPADAIRGEN6,
252+
"iPad14,9": IPADAIRGEN6,
253+
"iPad14,10": IPADAIRGEN7,
254+
"iPad14,11": IPADAIRGEN7,
255+
# iPad Pro
234256
"iPad6,7": IPADPRO12GEN1,
235-
"iPad6,8": IPADPRO12GEN1,
236257
"iPad6,3": IPADPRO9GEN1,
237258
"iPad6,4": IPADPRO9GEN1,
259+
"iPad6,8": IPADPRO12GEN1,
238260
"iPad7,1": IPADPRO12GEN2,
239261
"iPad7,2": IPADPRO12GEN2,
240262
"iPad7,3": IPADPRO10,
@@ -259,6 +281,15 @@ def get_platform(device_os_name: str, is_emulator: bool) -> Platform:
259281
"iPad13,9": IPADPRO12GEN5,
260282
"iPad13,10": IPADPRO12GEN5,
261283
"iPad13,11": IPADPRO12GEN5,
284+
"iPad14,3": IPADPRO11GEN4,
285+
"iPad14,4": IPADPRO11GEN4,
286+
"iPad14,5": IPADPRO12GEN6,
287+
"iPad14,6": IPADPRO12GEN6,
288+
"iPad16,3": IPADPRO11GEN5,
289+
"iPad16,4": IPADPRO11GEN5,
290+
"iPad16,5": IPADPRO12GEN7,
291+
"iPad16,6": IPADPRO12GEN7,
292+
# iPad Mini
262293
"iPad2,5": IPADMINIGEN1,
263294
"iPad2,6": IPADMINIGEN1,
264295
"iPad2,7": IPADMINIGEN1,
@@ -276,10 +307,7 @@ def get_platform(device_os_name: str, is_emulator: bool) -> Platform:
276307
"iPad13,19": IPADGEN10,
277308
"iPad14,1": IPADMINIGEN6,
278309
"iPad14,2": IPADMINIGEN6,
279-
"iPad14,3": IPADPRO11GEN4,
280-
"iPad14,4": IPADPRO11GEN4,
281-
"iPad14,5": IPADPRO12GEN6,
282-
"iPad14,6": IPADPRO12GEN6,
310+
# Apple Watch
283311
"Watch1,1": APPLEWATCHGEN1,
284312
"Watch1,2": APPLEWATCHGEN1,
285313
"Watch2,6": APPLEWATCHSERIES1,
@@ -298,12 +326,37 @@ def get_platform(device_os_name: str, is_emulator: bool) -> Platform:
298326
"Watch5,2": APPLEWATCHSERIES5,
299327
"Watch5,3": APPLEWATCHSERIES5,
300328
"Watch5,4": APPLEWATCHSERIES5,
301-
"Watch5,9": APPLEWATCHSE,
302-
"Watch5,10": APPLEWATCHSE,
303-
"Watch5,11": APPLEWATCHSE,
304-
"Watch5,12": APPLEWATCHSE,
305329
"Watch6,3": APPLEWATCHSERIES6,
306330
"Watch6,4": APPLEWATCHSERIES6,
331+
"Watch6,6": APPLEWATCHSERIES7,
332+
"Watch6,7": APPLEWATCHSERIES7,
333+
"Watch6,8": APPLEWATCHSERIES7,
334+
"Watch6,9": APPLEWATCHSERIES7,
335+
"Watch6,14": APPLEWATCHSERIES8,
336+
"Watch6,15": APPLEWATCHSERIES8,
337+
"Watch6,16": APPLEWATCHSERIES8,
338+
"Watch6,17": APPLEWATCHSERIES8,
339+
"Watch7,1": APPLEWATCHSERIES9,
340+
"Watch7,2": APPLEWATCHSERIES9,
341+
"Watch7,3": APPLEWATCHSERIES9,
342+
"Watch7,4": APPLEWATCHSERIES9,
343+
"Watch7,8": APPLEWATCHSERIES10,
344+
"Watch7,9": APPLEWATCHSERIES10,
345+
"Watch7,10": APPLEWATCHSERIES10,
346+
"Watch7,11": APPLEWATCHSERIES10,
347+
# Apple Watch SE
348+
"Watch5,9": APPLEWATCHSE1,
349+
"Watch5,10": APPLEWATCHSE1,
350+
"Watch5,11": APPLEWATCHSE1,
351+
"Watch5,12": APPLEWATCHSE1,
352+
"Watch6,10": APPLEWATCHSE2,
353+
"Watch6,11": APPLEWATCHSE2,
354+
"Watch6,12": APPLEWATCHSE2,
355+
"Watch6,13": APPLEWATCHSE2,
356+
# Apple Watch Ultra
357+
"Watch6,18": "Apple Watch Ultra (1st gen)",
358+
"Watch7,5": "Apple Watch Ultra (2nd gen)",
359+
# Apple TV
307360
"AppleTV1,1": "Apple TV (1st gen)",
308361
"AppleTV2,1": "Apple TV (2nd gen)",
309362
"AppleTV3,1": APPLETVGEN3,
@@ -315,21 +368,6 @@ def get_platform(device_os_name: str, is_emulator: bool) -> Platform:
315368
"x86_64": "iOS Simulator (x86_64)",
316369
}
317370

318-
319-
def ios_human_readable_model_name(model: str) -> str:
320-
if model in IOS_MODELS:
321-
return IOS_MODELS[model]
322-
if model.startswith("iPhone"):
323-
return "Unknown iPhone"
324-
if model.startswith("iPad"):
325-
return "Unknown iPad"
326-
if model.startswith("AppleTV"):
327-
return "Unknown Apple TV"
328-
if model.startswith("Watch"):
329-
return "Unknown Apple Watch"
330-
return "Unknown iOS Device"
331-
332-
333371
CPU1 = (520, 520)
334372
CPU2 = (1000, 1000)
335373
CPU3 = (1300, 1300)

0 commit comments

Comments
 (0)