Capturing RouteError fails unexpectedly #16314
Assignees
Comments
jeffkwoh
pushed a commit
to jeffkwoh/sentry
that referenced
this issue
Jan 8, 2020
Wraps unreproducible Type Error (missing setter) in Error.message property in a try-catch. Type Error is unreproducible, and when thrown causes intital error to be ignored and the newer and less informative Type Error to be captured by Sentry instead. Currently, a minority of users are affected and certain browser and/or browser extension incompatibility is suspected. Suppression should help in the discovery of the actual errors causing the RouteError and perhaps uncover the root cause of the Type Error. Fixes getsentryGH-16314 Fixes Sentry-JAVASCRIPT-129Q
jeffkwoh
added a commit
that referenced
this issue
Jan 9, 2020
fix: Capture unexpected Type Error in capturing RouteError Wraps unreproducible TypeError (missing setter) in Error.message property in a try-catch. When the TypeError is thrown it causes the initial RouteError to be ignored and the newer and less informative TypeError to be captured by Sentry instead. Currently, a minority of users are affected and certain browser and/or browser extension incompatibility is suspected. By capturing the new TypeError, and returning to the RouteError context, we are then able to capture the emitted RouteError. This should help in the discovery of the actual errors causing the RouteError and perhaps uncover the root cause of the TypeError. Fixes GH-16314 Fixes Sentry-JAVASCRIPT-129Q
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Sometimes when capturing a RouteError, writing to the
messageproperty of JavaScript'sErrorobject causes aType Error: setting getter-only property "message".The new Type Error exception thrown is then logged into Sentry, causing the previous RouteError to be discarded.
While instances are captured in Sentry, these errors are not reproducible. The
messageproperty should be writable, it is unclear why these errors are being thrown in this scenario. @billyvg suspects browser or browser extension incompatibility.The text was updated successfully, but these errors were encountered: