Skip to content

INC-454 Metric Alerts Ratelimiting #54730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wedamija opened this issue Aug 14, 2023 · 0 comments · Fixed by #58032
Closed

INC-454 Metric Alerts Ratelimiting #54730

wedamija opened this issue Aug 14, 2023 · 0 comments · Fixed by #58032
Assignees
@isabellaenriquez
Milestone
Incident Remediation

Comments

@wedamija
Copy link
Member

wedamija commented Aug 14, 2023 •
edited by scefali
Loading

Action item from https://www.notion.so/sentry/INC-454-Metric-alerts-misfiring-96cd3b3c49374f159d75f0b7e27e7ed3

The simplest and easiest rate limiter we can do with metric alerts is to simply prevent it from firing more often than every x minutes (let's say 10 minutes). This can be figured out from the Incident model which tracks each time a metric alert incident fires. If it has been less than 10 minutes since the last incident opened, we should not open another incident.
@brianthi brianthi added this to the Incident Remediation milestone Aug 23, 2023
@brianthi brianthi assigned 17hogeju and unassigned armenzg Sep 7, 2023
@isabellaenriquez isabellaenriquez mentioned this issue Oct 12, 2023
Merged
isabellaenriquez added a commit that referenced this issue Oct 23, 2023
@isabellaenriquez
feat(alerts): Add ratelimiting for metric alerts (#58032)
03e3b04 
Ratelimiting is added (under an options-backed feature flag) to ensure
metric alerts don't fire more than every 10 minutes. Action item from
INC-454.

Closes #54730
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isabellaenriquez isabellaenriquez

Labels
None yet
Projects
None yet
Milestone
Incident Remediation
Development

Successfully merging a pull request may close this issue.

feat(alerts): Add ratelimiting for metric alerts getsentry/sentry
7 participants
@armenzg @brianthi @wedamija @NisanthanNanthakumar @snigdhas @17hogeju @isabellaenriquez