Skip to content

[Feature Flag Insights] Add Sentry Feedback Button #77399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jas-kas opened this issue Sep 12, 2024 · 1 comment · Fixed by #77488
Closed

[Feature Flag Insights] Add Sentry Feedback Button #77399

jas-kas opened this issue Sep 12, 2024 · 1 comment · Fixed by #77488
Assignees
@michellewzhang

Comments

@jas-kas
Copy link
Member

jas-kas commented Sep 12, 2024 •
edited by bruno-garcia
Loading

Add Sentry Feedback Button to flyout page for the Issue Details Feature Flag UI (seen when all FFs are expanded) or directly inline with the header. Similar to Breadcrumbs and Hydration Error modal UI.

Image

Image

Related to:
@jas-kas jas-kas moved this to Todo in 🎏 Feature Flags Sep 12, 2024
@jas-kas
Copy link
Member Author

jas-kas commented Sep 12, 2024

cc/ @michellewzhang

@michellewzhang michellewzhang self-assigned this Sep 12, 2024
@michellewzhang michellewzhang mentioned this issue Sep 12, 2024
Merged
michellewzhang added a commit that referenced this issue Sep 13, 2024
@michellewzhang
feat(issues/flags): add ui for feature flag table in event details (#…
1619a77 
…77218)

### Feature Flag UI
- Adds a feature flag UI component in event details (under a feature
flag, only visible to sentry orgs) showing a list of the organization's
evaluated feature flags. This component sits below the event contexts.
- The default sort order is evaluation order. The component shows a max
of 10 rows & 2 columns.
- `View All` opens up a drawer similar to the breadcrumbs drawer,
showing all feature flags w/ ability to sort & search.

### Followup
- Will add a feedback button in a followup PR
([ticket](#77399))
- Will add analytics in a followup PR

With real data:

![SCR-20240912-kpjn](https://github.com/user-attachments/assets/50f064d5-ea21-482a-aad4-a2b7c0051266)


With more robust fake data:


https://github.com/user-attachments/assets/f4556288-7b13-4afc-88de-df15a3999830

With 1 column of flags:
<img width="1009" alt="SCR-20240912-jjct"
src="https://github.com/user-attachments/assets/641f0851-2f68-4af3-af36-ccb47c4d7775">





-
[Figma](https://www.figma.com/design/oTVOd3RGUSZWYGwTpGjeGK/Specs%3A-Feature-Flag-List-in-Issue-Details?node-id=212-1627&node-type=canvas&t=DGQBOPYIbvPzXy2R-0)
- Relates to #77160
@michellewzhang michellewzhang mentioned this issue Sep 13, 2024
Merged
michellewzhang added a commit that referenced this issue Sep 13, 2024
@michellewzhang
feat(flags): hide flags from context and add feedback button (#77488)
f9db85f 
## add give feedback button:
it wouldn't show up in the drawer for some reason so added it to the
main component action bar:


https://github.com/user-attachments/assets/ef3b778e-daa2-4fc1-9cad-3b93d8ad4deb

## remove `flags` from the context display
<img width="996" alt="SCR-20240913-jueq"
src="https://github.com/user-attachments/assets/80697333-062d-41ca-800d-41529ead0112">

closes #77399
closes #77160
@github-project-automation github-project-automation bot moved this from Todo to Done in 🎏 Feature Flags Sep 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@michellewzhang michellewzhang

Labels
None yet
Projects
🎏 Feature Flags
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(flags): hide flags from context and add feedback button getsentry/sentry
2 participants
@michellewzhang @jas-kas