Skip to content

[WIP] ref(ui): upgrade grid-emotion to @rebass/grid #12747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

[WIP] ref(ui): upgrade grid-emotion to @rebass/grid #12747

wants to merge 5 commits into from

Conversation

ckj
Copy link
Member

@ckj ckj commented Apr 11, 2019 •
edited
Loading

This branch updates grid-emotion package to @rebass/grid/emotion. The work primarily includes:

  • Updating the imports
  • updating the props:
    • w to width
    • direction to flexDirection
    • wrap to flexWrap
    • align to alignItems
    • justify to justifyContent
  • Defining a space scale in theme, as the updated default no longer matches the original

This was a huge find and replace job. While I've spot checked the primary views, I'm leaning heavily on Percy and app team reviewers to help spot any unintentional changes.

Todos:

  • Convert handful of grid-emotion components in getsentry

@ckj ckj added the WIP label Apr 11, 2019
@ckj ckj marked this pull request as ready for review April 12, 2019 17:48
@ckj
Copy link
Member Author

ckj commented Jan 10, 2020

Closing in favor of #15106

@ckj ckj closed this Jan 10, 2020
@evanpurkhiser evanpurkhiser deleted the ref/ui/rebass-grid branch October 13, 2020 22:36
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ckj