-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(ci): do not install_egg_info to fix importlib_metadata not found #15255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Dang, adding the importlib backport explicitly led to
And pinning pluggy back down to 0.11.0 results in the same. Actually forcing pluggy back down will break during runtime:
|
Yep, looks like it was because we did EDIT: see #15255 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok, not sure if there was some reason we installed eggs in ci?
Don't really know much about eggs, but I suspect it has something to do with testing sentry releases...? @mattrobenolt is this Edit: @BYK see above^ |
Hmm, ci in master seems to be working again. Probably some weird caching stuff, but I wanna say travis caching is per pr/branch. Wonder if the real solution was just to nuke travis cache (which was done during this pr). Because I was confused reading pytest-dev/pluggy#205 since the egg issues seem to have been fixed. Anyways, I don't think these changes hurt anything. |
So this was added by @mitsuhiko in #10654. Not sure you asked for my review but I don't have anything intelligent to say 😀 Yielding to @mitsuhiko |
Oh, matt just guessed you'd have more context. (I didn't try and follow the git blame trail, haha) |
@BYK it clearly says workaround ;) You overstate my comprehension of the nightmare that is python packaging. |
@mitsuhiko, what I meant was I have no idea whether we still need this workaround or not and you were the closest to this car crash 😁 |
From my understand we still need it. Yes. Otherwise travis will break on certain dependency changes. |
pluggy (via pytest)'s complaining about importlib_metadata again. This happened with the Riak test suite, which was removed (#15072) after I noticed it was deprecated. Back then, that was the path of least resistance, but now the issue's come back.
Related: pytest-dev/pluggy#205