fix(discover2): Various fixes #15315
Conversation
dashed
force-pushed
the
discover2-fixes-oct-29-2019
branch
from
54cfce6 to
de14b90
Compare
|
|
||
| import {URL_PARAM} from 'app/constants/globalSelectionHeader'; | ||
|
|
||
| // Parses URL query parameters for values relevant to global selection header | ||
| export function getStateFromQuery(query) { | ||
| let start = query[URL_PARAM.START] !== 'null' && query[URL_PARAM.START]; | ||
| let end = query[URL_PARAM.END] !== 'null' && query[URL_PARAM.END]; | ||
| const parsedParams = getParams(query); |
There was a problem hiding this comment.
I'm seeing some issues stemming from the global selection header propagating down to discover2.
Invalid datetime selections can easily throw an error and break the app with no actual recovery flow.
I feel it's better to parse and validate the datetime selection early here; rather than doing it at the API payload generation everywhere.
| @@ -2,17 +2,20 @@ import {pick, pickBy, identity} from 'lodash'; | |||
|
|
|||
| import {defined} from 'app/utils'; | |||
| import {getUtcToLocalDateObject} from 'app/utils/dates'; | |||
| import {getParams} from 'app/views/events/utils/getParams'; | |||
There was a problem hiding this comment.
Should this function be moved to live with the other global selection functions?
There was a problem hiding this comment.
I'll see if I can move getParams to this file.
|
|
||
| const getDateTimeString = ( | ||
| maybe: string | string[] | undefined | null | ||
| ): string | undefined => { |
There was a problem hiding this comment.
This and a few of the other parsers in this file have similar function bodies with only the validator/parsing operation being different. Could we extract that duplication?
dashed
force-pushed
the
discover2-fixes-oct-29-2019
branch
2 times, most recently
from
21bcc4b to
8af00b1
Compare
dashed
force-pushed
the
discover2-fixes-oct-29-2019
branch
from
64b3447 to
954c129
Compare
Some various fixes:
The table metadata could be
null, so we mark it as potentiallynull, and add guards as necessary.If either
start/endquery string is provided, it may be missingend/startrespectively, and easily break discover2; especially when URLs are meant to be shareable. This can occur in copy/paste mishaps. As a fallback, thestatsPeriodwill be coerced to a value of14d.Parse and validate
statsPeriod,start, andendquery strings at the global selection header store.normalize datetime strings from
startandendto beYYYY-MM-DDTHH:mm:ss.SSSProperly parse datetime strings in
EventView.fromLocation()andEventView. fromSavedQuery()TODO
getParamsto the global selection header folder.