Skip to content

feat(discv2): event breakdown #16142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Dec 18, 2019
Merged

feat(discv2): event breakdown #16142

merged 9 commits into from
Dec 18, 2019

Conversation

doralchan
Copy link
Contributor

@doralchan doralchan commented Dec 17, 2019 •
edited
Loading

Screen Shot 2019-12-18 at 12 12 23 PM

@doralchan doralchan force-pushed the feat/discv2-breakdown-circles branch 2 times, most recently from 3d22772 to 7acbf88 Compare December 18, 2019 18:39
@doralchan doralchan requested review from dashed and a team December 18, 2019 18:55
@doralchan doralchan force-pushed the feat/discv2-breakdown-circles branch from a339b6d to 1f37d1c Compare December 18, 2019 19:18
@doralchan doralchan requested a review from leedongwei December 18, 2019 20:12
dashed
dashed approved these changes Dec 18, 2019
View reviewed changes
Copy link
Member

@dashed dashed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@doralchan doralchan merged commit 6a5425f into master Dec 18, 2019
@doralchan doralchan deleted the feat/discv2-breakdown-circles branch December 18, 2019 21:13
scefali pushed a commit that referenced this pull request Dec 23, 2019
@doralchan
feat(discv2): event breakdown (#16142)
266ad0f 
* event breakdown setup

* styling list

* added color

* show 4

* recalculate percent

* fixing percentages

* fixing calculations

* rounding percent

* changing currentOp to currOp and css resort
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dashed dashed dashed approved these changes

@leedongwei leedongwei leedongwei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@doralchan @dashed @leedongwei