Skip to content

ref(css): Remove CSS class event-issue-header #18437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2020
Merged

ref(css): Remove CSS class event-issue-header #18437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/sentry/static/sentry/app/components/eventOrGroupHeader.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import React from 'react';
import {withRouter} from 'react-router';
import styled from '@emotion/styled';
import {css} from '@emotion/core';
import classNames from 'classnames';
import capitalize from 'lodash/capitalize';

import SentryTypes from 'app/sentryTypes';
Expand Down Expand Up @@ -88,12 +87,11 @@ class EventOrGroupHeader extends React.Component {

render() {
const {className, size, data} = this.props;
const cx = classNames('event-issue-header', className);
const location = getLocation(data);
const message = getMessage(data);

return (
<div className={cx}>
<div className={className} data-test-id="event-issue-header">
<Title size={size}>{this.getTitle()}</Title>
{location && <Location size={size}>{location}</Location>}
{message && <Message size={size}>{message}</Message>}
Expand Down
24 changes: 0 additions & 24 deletions src/sentry/static/sentry/less/stream.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,27 +936,3 @@
}
}
}

.event-issue-header {
h3 {
font-size: 16px;
line-height: 1.1;
margin: 0 0 5px;
font-weight: 600;

em {
font-style: normal;
font-size: 14px;
color: @60;
font-weight: normal;
}

a {
color: @gray-darker;

&:hover {
color: @gray-darkest;
}
}
}
}
2 changes: 1 addition & 1 deletion tests/acceptance/page_objects/issue_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def visit_issue_list(self, org, query=""):
self.wait_until_loaded()

def wait_for_stream(self):
self.browser.wait_until(".event-issue-header", timeout=20)
self.browser.wait_until('[data-test-id="event-issue-header"]', timeout=20)

def select_issue(self, position):
self.browser.click(u'[data-test-id="group"]:nth-child({})'.format(position))
Expand Down
2 changes: 1 addition & 1 deletion tests/acceptance/test_organization_group_index.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def test_with_results(self, mock_now):
self.page.wait_for_stream()
self.browser.snapshot("organization issues with issues")

groups = self.browser.find_elements_by_class_name("event-issue-header")
groups = self.browser.find_elements_by_css_selector('[data-test-id="event-issue-header"]')
assert len(groups) == 2
assert "oh snap" in groups[0].text
assert "oh no" in groups[1].text
Expand Down
4 changes: 2 additions & 2 deletions tests/js/spec/views/organizationGroupDetails/__snapshots__/groupMergedView.spec.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -987,7 +987,7 @@ exports[`Issues -> Merged View renders with mocked data 1`] = `
size="normal"
>
<div
className="event-issue-header"
data-test-id="event-issue-header"
>
<Title
size="normal"
Expand Down Expand Up @@ -1736,7 +1736,7 @@ exports[`Issues -> Merged View renders with mocked data 1`] = `
size="normal"
>
<div
className="event-issue-header"
data-test-id="event-issue-header"
>
<Title
size="normal"
Expand Down
2 changes: 1 addition & 1 deletion tests/js/spec/views/organizationGroupDetails/__snapshots__/groupSimilar.spec.jsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,7 +835,7 @@ exports[`Issues Similar View renders with mocked data 1`] = `
size="normal"
>
<div
className="event-issue-header"
data-test-id="event-issue-header"
>
<Title
size="normal"
Expand Down