fix(alerts): Make clear that superuser may edit comments #18455
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
reviewed
Apr 24, 2020
| } | ||
|
|
||
| const NoteHeader = ({authorName, user, onEdit, onDelete}: Props) => ( | ||
| <div> | ||
| <ActivityAuthor>{authorName}</ActivityAuthor> | ||
| {canEdit(user) && ( | ||
| <EditorTools> | ||
| <Edit onClick={onEdit}>{t('Edit')}</Edit> | ||
| <Tooltip | ||
| title={t('You can edit this comment due to your superuser status')} |
There was a problem hiding this comment.
Should delete have a similar tooltip?
There was a problem hiding this comment.
Yeah may as well :)
evanpurkhiser
force-pushed
the
evanpurkhiser/fixalerts-make-clear-that-superuser-may-edit-comments
branch
from
5541f9f to
118b7c3
Compare
evanpurkhiser
deleted the
evanpurkhiser/fixalerts-make-clear-that-superuser-may-edit-comments
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the backend endpoint to allow superuser mutation
Adds this tooltip too.