Skip to content

fix(dev): pre-commit virtualenv 20.0.23 -> 20.0.32 #21146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

joshuarli
Copy link
Member

Currently in a fresh py3 venv, when running make setup-git you'll get the nonfatal:

ERROR: After October 2020 you may experience errors when installing or updating packages. This is because pip will change the way that it resolves dependency conflicts.

We recommend you use --use-feature=2020-resolver to test your packages with the new resolver before it becomes the default.

virtualenv 20.0.23 requires importlib-metadata<2,>=0.12; python_version < "3.8", but you'll have importlib-metadata 2.0.0 which is incompatible.

This upgrades virtualenv (for pre-commit) to 20.0.32 which includes the fix: pypa/virtualenv#1953. pre-commit does not yet have an upper pin for virtualenv which caused problems in the past with virtualenv, see #19256.

Tested in provisioning a fresh venv in both py2 + py3.

@joshuarli joshuarli requested a review from a team October 5, 2020 19:16
@joshuarli joshuarli merged commit 063f603 into master Oct 5, 2020
@joshuarli joshuarli deleted the dev/upgrade-pre-commit-virtualenv branch October 5, 2020 19:51
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants