Skip to content

feat(misc): Add platform categories for backend code #37894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 18, 2022

Conversation

PixelDust22
Copy link
Contributor

This mirrors the same file on the frontend and it allows us to check if a platform is mobile or not.

@PixelDust22 PixelDust22 requested a review from scefali August 16, 2022 23:25
@github-actions github-actions bot added Scope: Frontend Automatically applied to PRs that change frontend components Scope: Backend Automatically applied to PRs that change backend components labels Aug 16, 2022
@github-actions
Copy link
Contributor

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

Copy link
Contributor

@scefali scefali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neo-Zhixing I'm concerned about copying the full contents of this file here as we don't really need it. I know you have a note to update this file, but people are going to inevitably forget it. Can we just use the mobile list for now?

@PixelDust22
Copy link
Contributor Author

imo it's better to hard code the list than copying just the mobile section (there are a few places in the code base that are doing this btw).

A better approach might be creating a JSON file that the frontend and the backend both reads, however that'll be a lot more difficult to do. Calling for modifying both files is the right thing to do here imo.

Wonder what others would think about this.

@PixelDust22 PixelDust22 enabled auto-merge (squash) August 18, 2022 21:51
@PixelDust22 PixelDust22 merged commit 9652500 into master Aug 18, 2022
@PixelDust22 PixelDust22 deleted the feat/platform_categories_py branch August 18, 2022 21:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants