feat(mute-metric-alerts): Add mute button to metric alerts page #50967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
reviewed
Jun 15, 2023
Comment on lines
4
to
5
| import type {IssueAlertRule} from 'sentry/types/alerts'; | ||
| import {RuleActionsCategories} from 'sentry/types/alerts'; |
scttcper
reviewed
Jun 15, 2023
Comment on lines
+187
to
+193
| : tct( | ||
| "[creator] muted this alert[forEveryone]so you won't get these notifications in the future.", | ||
| { | ||
| creator: rule.snoozeCreatedBy, | ||
| forEveryone: rule.snoozeForEveryone ? ' for everyone ' : ' ', | ||
| } | ||
| )} |
There was a problem hiding this comment.
dumb question but wouldn't metric alerts always be for everyone or are we looking for specific email my team -> this user is muted
There was a problem hiding this comment.
you can set it to email a user or yeah if it's a team it emails each user in the team and one person can mute it for themselves.
scttcper
approved these changes
Jun 15, 2023
malwilley
approved these changes
Jun 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr adds in the mute button and banner showing mute status to the metric alerts page.