fix(compactSelect): Escape quotes inside option values #51007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompactSelectcrashes when there's a quote inside any option's value string, e.g.{value: 'hello"', label: …}Screen.Recording.2023-06-14.at.4.10.06.PM.mov
This happens because
react-aria'suseOverlay()hook query-selects option containers using a CSS selector string that contains the option's value:To fix this, we can escape each option's value string (using
CSS.escape()), making them safe for query selection. The escaped version is only used internally. TheonChange()callback will still return options with their initial, unescaped values.After the fix, quoted option values no longer cause a crash:
Screen.Recording.2023-06-14.at.4.14.46.PM.mov