fix(hybridcloud) Drain outbox after transaction completes #51059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should't drain outbox messages for memberships until after the member has committed, as we'll not be able to find the member. Fixes SENTRY-12D2
github-actions
bot
added
the
Scope: Backend
corps
approved these changes
Jun 15, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #51059 +/- ##
==========================================
+ Coverage 80.50% 81.22% +0.71%
==========================================
Files 4885 4885
Lines 204887 204888 +1
Branches 11123 11123
==========================================
+ Hits 164942 166414 +1472
+ Misses 39699 38228 -1471
Partials 246 246
|
dashed
approved these changes
Jun 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't drain outbox messages for memberships until after the member has committed, as we'll not be able to find the member.
Fixes SENTRY-12D2