Skip to content

fix(github-comments): remove extra slash from PATCH url #51711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2023
Merged

fix(github-comments): remove extra slash from PATCH url #51711

merged 2 commits into from
Jun 27, 2023

Conversation

cathteng
Copy link
Member

@cathteng cathteng requested review from AniketDas-Tekky and a team June 27, 2023 16:40
@cathteng cathteng requested a review from a team as a code owner June 27, 2023 16:40
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 27, 2023
@cathteng cathteng enabled auto-merge (squash) June 27, 2023 16:43
@codecov
Copy link

codecov bot commented Jun 27, 2023 •
edited
Loading

Codecov Report

Merging #51711 (3bb921f) into master (d66f884) will increase coverage by 0.25%.
The diff coverage is 100.00%.

❗ Current head 3bb921f differs from pull request most recent head 615ddc5. Consider uploading reports for the commit 615ddc5 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #51711     +/-   ##
=========================================
+ Coverage    81.03    81.28   +0.25     
=========================================
  Files        4893     4893             
  Lines      205520   205520             
  Branches    11068    11068             
=========================================
+ Hits       166534   167053    +519     
+ Misses      38741    38222    -519     
  Partials      245      245
Impacted Files Coverage Δ
src/sentry/integrations/github/client.py 86.73% <100.00%> (ø)

... and 30 files with indirect coverage changes

AniketDas-Tekky
AniketDas-Tekky approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@AniketDas-Tekky AniketDas-Tekky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mocks need to be updated

@cathteng cathteng merged commit bd41029 into master Jun 27, 2023
@cathteng cathteng deleted the cathy/github-comments/remove-extra-slash-patch branch June 27, 2023 18:30
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dashed dashed dashed approved these changes

@scefali scefali scefali approved these changes

@schew2381 schew2381 schew2381 approved these changes

@AniketDas-Tekky AniketDas-Tekky AniketDas-Tekky approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cathteng @dashed @scefali @schew2381 @AniketDas-Tekky