Skip to content

chore(gh-comments): Drop pr window to 7 days for rollout #51837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 6, 2023

Conversation

AniketDas-Tekky
Copy link
Contributor

Based on an ask from product

@AniketDas-Tekky AniketDas-Tekky requested a review from a team June 28, 2023 20:57
@AniketDas-Tekky AniketDas-Tekky requested a review from a team as a code owner June 28, 2023 20:57
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 28, 2023
Copy link
Member

@cathteng cathteng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test needs to be fixed test_gh_comment_pr_too_old in test_commit_context.py

@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #51837 (9df1204) into master (ba371da) will increase coverage by 3.79%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #51837     +/-   ##
=========================================
+ Coverage    77.52    81.31   +3.79     
=========================================
  Files        4872     4900     +28     
  Lines      205378   205717    +339     
  Branches    11049    11049             
=========================================
+ Hits       159199   167268   +8069     
+ Misses      45934    38204   -7730     
  Partials      245      245             
Impacted Files Coverage Δ
src/sentry/tasks/commit_context.py 89.51% <100.00%> (+0.07%) ⬆️

... and 530 files with indirect coverage changes

@AniketDas-Tekky AniketDas-Tekky merged commit 5a63ff0 into master Jul 6, 2023
@AniketDas-Tekky AniketDas-Tekky deleted the adas/gh-commment-bot/reduce-pr-window branch July 6, 2023 19:35
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants