nit: Update fly build config #52301
Merged
nit: Update fly build config #52301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
EricHasegawa
reviewed
Jul 5, 2023
| """ | ||
| On configuration, we determine which provider organization to configure sentry SSO for. | ||
| This configuration is then stored and passed into the pipeline instances during SSO | ||
| to determine whether the Auth'd user has the appropriate access to the provider org | ||
| """ | ||
| org = organization | ||
| if not organization: |
There was a problem hiding this comment.
Are we sure this is safe to take out? Is it possible for id to not be in resource? And if so, how do we handle that case with the new code?
There was a problem hiding this comment.
Ah yea
So this isn't being utilized anywhere atm.
Since this is specific per provider, we can shape this build_config however we want per provider.
for Fly in particular, their organization resource will always have an 'id'
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52301 +/- ##
==========================================
- Coverage 79.31% 76.92% -2.39%
==========================================
Files 4906 4906
Lines 205540 205536 -4
Branches 35135 35134 -1
==========================================
- Hits 163020 158117 -4903
- Misses 37538 42327 +4789
- Partials 4982 5092 +110
|
EricHasegawa
approved these changes
Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cleans up the build_config method