Skip to content

ref(crons): Change to uuid validator for trace #52561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 17, 2023
Merged

ref(crons): Change to uuid validator for trace #52561

merged 2 commits into from
Jul 17, 2023

Conversation

rjo100
Copy link
Contributor

@rjo100 rjo100 commented Jul 10, 2023

Fixes an overlooked comment from an old PR

@rjo100 rjo100 requested a review from a team as a code owner July 10, 2023 19:41
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 10, 2023
@codecov
Copy link

codecov bot commented Jul 17, 2023 •
edited
Loading

Codecov Report

Merging #52561 (68f1436) into master (b3f6334) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #52561      +/-   ##
==========================================
- Coverage   79.46%   79.44%   -0.02%     
==========================================
  Files        4936     4938       +2     
  Lines      207392   207906     +514     
  Branches    35422    35496      +74     
==========================================
+ Hits       164796   165175     +379     
- Misses      37560    37691     +131     
- Partials     5036     5040       +4
Impacted Files Coverage Δ
...c/app/views/organizationStats/usageChart/utils.tsx 52.08% <ø> (ø)
src/sentry/monitors/validators.py 91.24% <100.00%> (ø)

... and 293 files with indirect coverage changes

@rjo100 rjo100 merged commit e558a85 into master Jul 17, 2023
@rjo100 rjo100 deleted the rjo100/improve-checkin-validator branch July 17, 2023 20:05
@github-actions github-actions bot locked and limited conversation to collaborators Aug 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidenwang davidenwang davidenwang approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rjo100 @davidenwang