feat(crons): Use timeout_at for timed out check-ins #52570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
rjo100
commented
Jul 11, 2023
| "monitor", "monitor_environment" | ||
| )[:CHECKINS_LIMIT] | ||
| qs = MonitorCheckIn.objects.filter( | ||
| status=CheckInStatus.IN_PROGRESS, timeout_at__lte=current_datetime |
There was a problem hiding this comment.
would it be worth changing the query to
Q(timeout_at__lte=current_datetime) | Q(timeout_at=None)
as a safety precaution? we don't have any null values currently but would be a good protection in case there's a regression so we don't ignore the null timeouts. could also put it in a separate query
There was a problem hiding this comment.
Hmmm. Maybe we can add a metric that we put an alert on?
There was a problem hiding this comment.
I'll run a query and raise an exception at the bottom as a safety check
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52570 +/- ##
==========================================
- Coverage 79.46% 77.82% -1.64%
==========================================
Files 4936 4938 +2
Lines 207430 207943 +513
Branches 35425 35499 +74
==========================================
- Hits 164834 161835 -2999
- Misses 37559 41027 +3468
- Partials 5037 5081 +44
|
evanpurkhiser
approved these changes
Jul 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queries off of timestamp of
timeout_atfor in progress check-insCloses #52563