feat(github-growth): allow hiding repos #52766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52766 +/- ##
=======================================
Coverage 79.37% 79.37%
=======================================
Files 4921 4921
Lines 206601 206603 +2
Branches 35315 35316 +1
=======================================
+ Hits 163983 163997 +14
+ Misses 37592 37584 -8
+ Partials 5026 5022 -4
|
cathteng
commented
Jul 12, 2023
nhsiehgit
approved these changes
Jul 13, 2023
schew2381
reviewed
Jul 13, 2023
| @@ -20,6 +20,7 @@ class RepositorySerializer(serializers.Serializer): | |||
| # XXX(dcramer): these are aliased, and we prefer 'active' over 'visible' | |||
| ("visible", "visible"), | |||
| ("active", "active"), | |||
| ("hidden", "hidden"), | |||
There was a problem hiding this comment.
Just curious, why do we set choices as a tuple with duplicate values?
There was a problem hiding this comment.
i think sometimes you can have different values of what you allow to be sent to the API and what the serializer outputs as the value https://github.com/getsentry/sentry/blob/master/src/sentry/api/validators/servicehook.py#L10
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow setting a
Repositoryobject's status toObjectStatus.HIDDEN.For ER-1718