Skip to content

feat(github-growth): exclude hidden repos #52773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

cathteng
Copy link
Member

Don't return any hidden repositories in GET OrganizationRepositories.

For ER-1719

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #52773 (2def73b) into master (9afaa38) will increase coverage by 12.88%.
The diff coverage is 0.00%.

❗ Current head 2def73b differs from pull request most recent head aee4c44. Consider uploading reports for the commit aee4c44 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #52773       +/-   ##
===========================================
+ Coverage   66.49%   79.38%   +12.88%     
===========================================
  Files        4899     4922       +23     
  Lines      206427   206644      +217     
  Branches    35294    35320       +26     
===========================================
+ Hits       137273   164034    +26761     
+ Misses      64142    37587    -26555     
- Partials     5012     5023       +11     
Impacted Files Coverage Δ
.../sentry/api/endpoints/organization_repositories.py 71.87% <0.00%> (+18.64%) ⬆️

... and 1329 files with indirect coverage changes

@cathteng cathteng force-pushed the cathy/github-growth/exclude-hidden-repos branch from 2def73b to aee4c44 Compare July 13, 2023 17:29
@cathteng cathteng requested review from a team and AniketDas-Tekky July 13, 2023 20:38
@cathteng cathteng marked this pull request as ready for review July 13, 2023 20:39
external_id=54321,
provider="dummy",
config={"name": "getsentry/sentry"},
status=ObjectStatus.HIDDEN,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so status is an optional attr?

Is there already a test for multiple active repos?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no but i can add one

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default for status is ObjectStatus.ACTIVE

Copy link
Contributor

@nhsiehgit nhsiehgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nonblocking question

@cathteng cathteng enabled auto-merge (squash) July 13, 2023 20:47
@cathteng cathteng merged commit 09ceea5 into master Jul 13, 2023
@cathteng cathteng deleted the cathy/github-growth/exclude-hidden-repos branch July 13, 2023 21:17
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants