-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(github-growth): exclude hidden repos #52773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #52773 +/- ##
===========================================
+ Coverage 66.49% 79.38% +12.88%
===========================================
Files 4899 4922 +23
Lines 206427 206644 +217
Branches 35294 35320 +26
===========================================
+ Hits 137273 164034 +26761
+ Misses 64142 37587 -26555
- Partials 5012 5023 +11
|
2def73b
to
aee4c44
Compare
external_id=54321, | ||
provider="dummy", | ||
config={"name": "getsentry/sentry"}, | ||
status=ObjectStatus.HIDDEN, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so status
is an optional attr?
Is there already a test for multiple active repos?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no but i can add one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default for status is ObjectStatus.ACTIVE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
nonblocking question
Don't return any hidden repositories in GET OrganizationRepositories.
For ER-1719