Skip to content

fix(hc): Move OrganizationApiKeyDetailsEndpoint to control silo #52776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

mrduncan
Copy link
Member

@mrduncan mrduncan commented Jul 12, 2023

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #52776 (6ef66a3) into master (91316b1) will increase coverage by 26.78%.
The diff coverage is 100.00%.

❗ Current head 6ef66a3 differs from pull request most recent head 6e448b4. Consider uploading reports for the commit 6e448b4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #52776       +/-   ##
===========================================
+ Coverage   52.59%   79.37%   +26.78%     
===========================================
  Files        4885     4922       +37     
  Lines      205247   206642     +1395     
  Branches    35070    35319      +249     
===========================================
+ Hits       107952   164032    +56080     
+ Misses      95152    37586    -57566     
- Partials     2143     5024     +2881     
Impacted Files Coverage Δ
...ntry/api/endpoints/organization_api_key_details.py 85.71% <100.00%> (+40.47%) ⬆️

... and 1762 files with indirect coverage changes

@mrduncan mrduncan requested a review from a team July 13, 2023 03:35
The ApiKey model lives in the control silo.
@mrduncan mrduncan force-pushed the mrduncan/api-key-details-silo branch from 6e448b4 to 596f276 Compare July 13, 2023 19:54
@mrduncan mrduncan merged commit abac613 into master Jul 13, 2023
@mrduncan mrduncan deleted the mrduncan/api-key-details-silo branch July 13, 2023 20:24
mrduncan added a commit that referenced this pull request Jul 13, 2023
The ApiKey model lives in the control silo.

#52776 took care of the details endpoint
michellewzhang pushed a commit that referenced this pull request Jul 13, 2023
michellewzhang pushed a commit that referenced this pull request Jul 13, 2023
The ApiKey model lives in the control silo.

#52776 took care of the details endpoint
@github-actions github-actions bot locked and limited conversation to collaborators Jul 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants