Skip to content

ref(sort): Change betterPriority to priority #52910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2023
Merged

ref(sort): Change betterPriority to priority #52910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/app/components/modals/savedSearchModal/createSavedSearchModal.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ describe('CreateSavedSearchModal', function () {
data: {
name: 'new search name',
query: 'is:resolved',
sort: IssueSortOptions.BETTER_PRIORITY,
sort: IssueSortOptions.PRIORITY,
type: 0,
visibility: SavedSearchVisibility.OWNER,
},
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/modals/savedSearchModal/createSavedSearchModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ function validateSortOption({sort}: {sort?: string}) {
const sortOptions = [
IssueSortOptions.DATE,
IssueSortOptions.NEW,
IssueSortOptions.BETTER_PRIORITY,
IssueSortOptions.PRIORITY,
IssueSortOptions.FREQ,
IssueSortOptions.USER,
];
Expand Down
4 changes: 2 additions & 2 deletions static/app/components/modals/savedSearchModal/editSavedSearchModal.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ describe('EditSavedSearchModal', function () {
id: 'saved-search-id',
name: 'test',
query: 'is:unresolved browser:firefox',
sort: IssueSortOptions.BETTER_PRIORITY,
sort: IssueSortOptions.PRIORITY,
visibility: SavedSearchVisibility.OWNER,
},
});
Expand Down Expand Up @@ -97,7 +97,7 @@ describe('EditSavedSearchModal', function () {
id: 'saved-search-id',
name: 'test',
query: 'is:unresolved browser:firefox',
sort: IssueSortOptions.BETTER_PRIORITY,
sort: IssueSortOptions.PRIORITY,
visibility: SavedSearchVisibility.OWNER,
},
});
Expand Down
2 changes: 1 addition & 1 deletion static/app/components/modals/savedSearchModal/savedSearchModalContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export function SavedSearchModalContent({organization}: SavedSearchModalContentP
const sortOptions = [
IssueSortOptions.DATE,
IssueSortOptions.NEW,
IssueSortOptions.BETTER_PRIORITY,
IssueSortOptions.PRIORITY,
IssueSortOptions.FREQ,
IssueSortOptions.USER,
];
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/dashboards/datasetConfig/issues.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ function getTableSortOptions(_organization: Organization, _widgetQuery: WidgetQu
const sortOptions = [
IssueSortOptions.DATE,
IssueSortOptions.NEW,
IssueSortOptions.BETTER_PRIORITY,
IssueSortOptions.PRIORITY,
IssueSortOptions.FREQ,
IssueSortOptions.USER,
];
Expand Down
2 changes: 1 addition & 1 deletion static/app/views/dashboards/widgetBuilder/issueWidget/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ export const ISSUE_WIDGET_SORT_OPTIONS = [
IssueSortOptions.DATE,
IssueSortOptions.NEW,
IssueSortOptions.FREQ,
IssueSortOptions.BETTER_PRIORITY,
IssueSortOptions.PRIORITY,
IssueSortOptions.USER,
];

Expand Down
4 changes: 2 additions & 2 deletions static/app/views/issueList/actions/sortOptions.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ function getSortTooltip(key: IssueSortOptions) {
return t('When issue was flagged for review.');
case IssueSortOptions.NEW:
return t('First time the issue occurred.');
case IssueSortOptions.BETTER_PRIORITY:
case IssueSortOptions.PRIORITY:
return t('Recent issues trending upward.');
case IssueSortOptions.FREQ:
return t('Number of events.');
Expand All @@ -37,7 +37,7 @@ function IssueListSortOptions({onSelect, sort, query}: Props) {
...(FOR_REVIEW_QUERIES.includes(query || '') ? [IssueSortOptions.INBOX] : []),
IssueSortOptions.DATE,
IssueSortOptions.NEW,
IssueSortOptions.BETTER_PRIORITY,
IssueSortOptions.PRIORITY,
IssueSortOptions.FREQ,
IssueSortOptions.USER,
];
Expand Down
4 changes: 2 additions & 2 deletions static/app/views/issueList/utils.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ export type QueryCounts = Partial<Record<Query, QueryCount>>;
export enum IssueSortOptions {
DATE = 'date',
NEW = 'new',
BETTER_PRIORITY = 'betterPriority',
PRIORITY = 'priority',
FREQ = 'freq',
USER = 'user',
INBOX = 'inbox',
Expand All @@ -190,7 +190,7 @@ export function getSortLabel(key: string) {
switch (key) {
case IssueSortOptions.NEW:
return t('First Seen');
case IssueSortOptions.BETTER_PRIORITY:
case IssueSortOptions.PRIORITY:
return t('Priority');
case IssueSortOptions.FREQ:
return t('Events');
Expand Down